From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D70221FF15C for ; Fri, 17 Oct 2025 15:46:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1C0543CB; Fri, 17 Oct 2025 15:46:57 +0200 (CEST) Date: Fri, 17 Oct 2025 15:46:24 +0200 From: Wolfgang Bumiller To: Hannes Laimer Message-ID: References: <20250926125940.177661-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250926125940.177661-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760708780941 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [schema2rust.pm] Subject: [pdm-devel] applied: [PATCH proxmox] Schema2Rust: handle missing parameters->properties X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" applied, thanks On Fri, Sep 26, 2025 at 02:59:40PM +0200, Hannes Laimer wrote: > We crashed if we encountered > ``` > parameters => { > additionalProperties => 0, > }, > ``` > almost all endpoint specify this explicitly, so > ``` > parameters => { > additionalProperties => 0, > properties => {}, > }, > ``` > I found at least these > - `/cluster/firewall/options` > - `/cluster/firewall/macros` > to be exceptions to this, there may be more. > > Our api-macro does also not need this to be specified explicitly, > therefore we have the generator infer `properties => {}` in case it is > not specified explicitly, i.e. it is missing. > > Signed-off-by: Hannes Laimer > --- > pve-api-types/generator-lib/Schema2Rust.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/pve-api-types/generator-lib/Schema2Rust.pm b/pve-api-types/generator-lib/Schema2Rust.pm > index 0f3efc0a..7d600ae7 100644 > --- a/pve-api-types/generator-lib/Schema2Rust.pm > +++ b/pve-api-types/generator-lib/Schema2Rust.pm > @@ -1561,13 +1561,13 @@ my sub method_parameters : prototype($$$$$) { > > my $url_params = url_parameters($api_url); > > - my $parameters = $api_method->{parameters}; > + my $parameters = $api_method->{parameters} // {}; > > #print "URL PARAMETERS: ".join(', ', $url_params->@*)."\n"; > > # Clone to avoid modifying the duplicate. > $parameters = { $parameters->%* }; > - my $properties = { $parameters->{properties}->%* }; > + my $properties = { ($parameters->{properties} // {})->%* }; > $parameters->{properties} = $properties; > > # Handle URL parameter types. These should only be strings or integers. > -- > 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel