From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A2FB01FF0E4 for ; Tue, 28 Jul 2026 16:00:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 96CD721531; Tue, 28 Jul 2026 16:00:01 +0200 (CEST) Message-ID: Date: Tue, 28 Jul 2026 15:59:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner Subject: Re: [PATCH proxmox{,-backup,-datacenter-manager} 0/3] factor system report into shared crate To: Erik Fastermann , pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com References: <20260714083156.99794-1-e.fastermann@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20260714083156.99794-1-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785247159808 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.153 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XOSVNKRLDO44ZKLRZSVEEMYIXZ6B7LJV X-Message-ID-Hash: XOSVNKRLDO44ZKLRZSVEEMYIXZ6B7LJV X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/14/26 10:32 AM, Erik Fastermann wrote: > This series moves the system report logic that was duplicated in > PBS and PDM into a new shared proxmox-system-report crate. > > proxmox: > Adds the proxmox-system-report crate holding the common file, > command and function collection, the unified section order > (FILES, COMMANDS, FUNCTIONS) and the merged set of general commands > run on every product. > > proxmox-backup, proxmox-datacenter-manager: > Drop the duplicated logic and generate the report through the shared > crate, passing only their product specific files, commands and > functions. > > The report content stays the same apart from two intentional effects > of sharing one implementation: the top-level section order is now the > same for both products, and the general command set is the union of > what each ran before. PDM additionally emits FILES first now instead > of last. Product specific entries are untouched. Thanks for this patches, cleanups look in general good to me! Only left a few comments on individual patches, especially with respect to packaging, which warrant to be revisited IMO.