Re: [PATCH proxmox-backup 6/7] acme: fix #6372 implement ARI renewal information fetching.

[Manuel Federanko <m.federanko@proxmox.com>]

On 2026-07-27 3:30 PM, Shan Shaji wrote:
> On Thu Jun 25, 2026 at 4:13 PM CEST, Manuel Federanko wrote:
>> Try to fetch ARI renewal information and renew based on that, if it is
>> not available fall back to normal lifetime based renewal logic.
>>
>> The ARI check needs to talk to the server, move all checks into the
>> worker process and unconditionally call the worker process from all
>> entry points.
>>
>> Add a method that returns the ARI ID from the CertInfo struct, which is
>> easier than trying to pass along other information or switching to
>> proxmox-acme-api's CertificateInfo struct.
>>
>> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6372
>> Signed-off-by: Manuel Federanko <m.federanko@proxmox.com>
>> ---
>>  src/api2/node/certificates.rs          | 106 +++++++++++++++++++------
>>  src/bin/proxmox-daily-update.rs        |   6 --
>>  src/bin/proxmox_backup_manager/acme.rs |   8 --
>>  3 files changed, 81 insertions(+), 39 deletions(-)
>>
> [snip]
>> diff --git a/src/bin/proxmox_backup_manager/acme.rs b/src/bin/proxmox_backup_manager/acme.rs
>> index ed9e5868c..ea14cfe2b 100644
>> --- a/src/bin/proxmox_backup_manager/acme.rs
>> +++ b/src/bin/proxmox_backup_manager/acme.rs
>> @@ -413,14 +413,6 @@ pub fn plugin_cli() -> CommandLineInterface {
>>  )]
>>  /// Order a new ACME certificate.
>>  async fn order_acme_cert(param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
>> -    if !param["force"].as_bool().unwrap_or(false) {
>> -        let (expires_soon, lead_days) = api2::node::certificates::check_renewal_needed()?;
>> -        if !expires_soon {
>> -            println!("Certificate does not expire within the next {lead_days} days, not renewing.");
>> -            return Ok(());
>> -        }
>> -    }
>> -
> 
> Hi, Since this was now removed, we no longer get console feedback If the
> certificate doesn't expire soon. However, the status was visible inside the
> task log. Would showing it in the console as well be a good UX?
Agreed, I'd prefer that too, I'm unsure on how to achieve this, since the acme
check is imo better handled in the worker.
> 
>>      let info = &api2::node::certificates::API_METHOD_RENEW_ACME_CERT;
>>      let result = match info.handler {
>>          ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
>> --
>> 2.47.3
>