From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C05141FF189 for ; Thu, 4 Sep 2025 11:57:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC3CD2A4C7; Thu, 4 Sep 2025 11:57:56 +0200 (CEST) Message-ID: Date: Thu, 4 Sep 2025 11:57:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Dominik Csapak , Proxmox Datacenter Manager development discussion , Lukas Wagner References: <20250903114123.215787-1-l.wagner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756979856404 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox{-yew-comp, -datacenter-manager} v2 0/7] PVE node update view X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Am 04.09.25 um 11:30 schrieb Dominik Csapak: > in general the code and ui LGTM (with some minor cleanup potential) > > the only thing irking me is that the upgrade button is disabled > without further explanation for the user. > > @Thomas > i would apply this, and send some follow ups, > especially one where we overwrite the upgrade button > to open the nodes upgrade panel on the pve ui in a new tab for now > until we can tunnel the websocket and show it locally, what do you say? That's exactly what I talked with Lukas yesterday and indeed an OK stop gap. FWIW, we also briefly discussed the option of directly opening the target remotes xterm.js upgrade console, potentially providing both options (e.g. as split button). > alternatively, we can hide the button or the whole taskbar, but i would > not simply disable the upgrade button without any explanation or > way to do it... > No, some way to navigate to the target remote would be definitively good to have. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel