From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CBE561FF165 for ; Thu, 28 Aug 2025 21:46:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2CAC115D00; Thu, 28 Aug 2025 21:46:28 +0200 (CEST) Message-ID: Date: Thu, 28 Aug 2025 21:46:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Stefan Hanreich , Dominik Csapak References: <20250827113427.199253-1-s.hanreich@proxmox.com> <20250827113427.199253-5-s.hanreich@proxmox.com> <47aebe50-54e6-4f41-abbe-05363612bdd3@proxmox.com> Content-Language: en-US, de-DE From: Thomas Lamprecht In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756410378446 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH pve-network 1/6] sdn: api: return null for rollback / lock endpoints X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 28/08/2025 11:22, Stefan Hanreich wrote: > On 8/28/25 9:56 AM, Dominik Csapak wrote: >> while this (probably?, not to deep in the network code) fix, we should >> also either backport this to pve8 soon, or have a workaround in pdm >> so that older pve installs are still working > > the whole locking API is not available prior to PVE 9, so we'd need to > backport the whole series. not sure if we want to backport this to PVE > 8. What do you think @Thomas? not a fan, people wanting newer features should use newer PVE, gracefully handling older versions is still a must though. > We should either backport it or add some method of detecting > (potentially checking for method not allowed HTTP status?) this here and > printing an appropriate error message. Yeah, a explicit check for method not allowed/found code would be great. And just to be sure: the error should only happen if the too old remote is actually involved in the current operation. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel