From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 1/2] ui: pve tree: make name column collapse the text
Date: Wed, 29 Jan 2025 18:22:28 +0100 [thread overview]
Message-ID: <e182bcdb-271a-4f8e-a1ad-cae554634401@proxmox.com> (raw)
In-Reply-To: <20250129104450.1286995-1-d.csapak@proxmox.com>
Reading the subject painted the picture in my head that this is for
collapsing tree child elements, maybe reword this to:
ui: pve tree: ellipsize overly long guest name to avoid overflow
Am 29.01.25 um 11:44 schrieb Dominik Csapak:
Some short reasoning would be great; albeit I have to say that the subject
and the lack of doing this for VMs is the thing that mostly confused me,
with the subject clarified and either this being implemented for VMs too,
or stated why that is not required, I would be fine with the commit as is.
So, why just do this for CT names? A quick look at the code did not make
them look special compared to VM names (or even node name)
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-01-29 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 10:44 Dominik Csapak
2025-01-29 10:44 ` [pdm-devel] [PATCH datacenter-manager 2/2] server: api: task: return upid in status Dominik Csapak
2025-01-29 17:31 ` [pdm-devel] applied: " Thomas Lamprecht
2025-01-29 17:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e182bcdb-271a-4f8e-a1ad-cae554634401@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox