From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CFF891FF13B for ; Wed, 03 Jun 2026 13:49:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7DDDD9621; Wed, 3 Jun 2026 13:49:21 +0200 (CEST) Message-ID: Date: Wed, 3 Jun 2026 13:48:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [RFC PATCH datacenter-manager 1/4] server: connection: multi client: use correct client error for retrying To: Dominik Csapak , pdm-devel@lists.proxmox.com References: <20260529133026.3149896-1-d.csapak@proxmox.com> <20260529133026.3149896-2-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780487289862 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FTAKSWWHZ6V5B3GPXHUPYFOLL7NGEV6P X-Message-ID-Hash: FTAKSWWHZ6V5B3GPXHUPYFOLL7NGEV6P X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 01.06.26 um 09:19 schrieb Dominik Csapak: > > nice thanks, but after reading the commits wouldn't this now not also > retry the api call if it was a client one? > > it the first node returns a 'Client' error for any api call, > it will still retry on the second node, etc. ? > > the new code only does not retry the first node if it was a client > error? yeah, you're right, this was still not completely right, oof tracing the error behavior of the client libs and these edge cases here are really not that trivial... I pushed another follow-up, would be glad if you could cross-check that too for sanity: https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=commitdiff;h=c713876671f88d80bafdd3a1e7263644b4559da2