From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7D2411FF0E4 for ; Tue, 28 Jul 2026 16:00:01 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 70F11214A5; Tue, 28 Jul 2026 15:59:59 +0200 (CEST) Message-ID: Date: Tue, 28 Jul 2026 15:59:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner Subject: Re: [PATCH proxmox-datacenter-manager 3/3] report: use shared proxmox-system-report crate To: Erik Fastermann , pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com References: <20260714083156.99794-1-e.fastermann@proxmox.com> <20260714083156.99794-4-e.fastermann@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20260714083156.99794-4-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785247155749 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.154 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OHT6CBFWX26O3ZPRQKZA7NENZ4VYE32J X-Message-ID-Hash: OHT6CBFWX26O3ZPRQKZA7NENZ4VYE32J X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/14/26 10:31 AM, Erik Fastermann wrote: > Move the common report logic to the proxmox-system-report crate and > keep only the PDM specific files and commands here. > > User-visible output changes: > - section order is now FILES, COMMANDS, FUNCTIONS, matching PBS > (was COMMANDS, FUNCTIONS, FILES) > - adds dmidecode, lscpu and lspci output, previously PBS only > - the disk listing now covers all /dev/disk/by-* directories instead > of only by-id and by-path, matching PBS > > Product specific entries and their contents are otherwise unchanged. > > Suggested-by: Lukas Wagner > Suggested-by: Christian Ebner > Signed-off-by: Erik Fastermann same comments as for patch 2 apply here as well.