From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DECAC1FF16F for ; Tue, 2 Sep 2025 16:29:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C10916C2A; Tue, 2 Sep 2025 16:30:01 +0200 (CEST) Date: Tue, 2 Sep 2025 16:29:28 +0200 From: Wolfgang Bumiller To: Dominik Csapak Message-ID: References: <20250828131832.4058422-1-d.csapak@proxmox.com> <20250828131832.4058422-2-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250828131832.4058422-2-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756823354810 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v4 01/10] pdm-api-types: resources: add helper methods for fields X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Thu, Aug 28, 2025 at 03:16:00PM +0200, Dominik Csapak wrote: > namely 'resource_type' and 'status'. All resources have those fields > in one way or another, so adding a helper that one does not have to > use `match` on every call site makes code there shorter. > > Signed-off-by: Dominik Csapak > --- > no changes in v4 > lib/pdm-api-types/src/resource.rs | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/lib/pdm-api-types/src/resource.rs b/lib/pdm-api-types/src/resource.rs > index 6227855..0dfadd5 100644 > --- a/lib/pdm-api-types/src/resource.rs > +++ b/lib/pdm-api-types/src/resource.rs > @@ -62,6 +62,33 @@ impl Resource { > Resource::PbsDatastore(r) => r.name.as_str(), > } > } > + > + pub fn resource_type(&self) -> &str { ^ This may be nicer as simple `enum` with a `Display`/`FromStr` implementation. > + match self { > + Resource::PveStorage(_) => "storage", > + Resource::PveQemu(_) => "qemu", > + Resource::PveLxc(_) => "lxc", > + Resource::PveNode(_) | Resource::PbsNode(_) => "node", > + Resource::PbsDatastore(_) => "datastore", > + } > + } > + > + pub fn status(&self) -> &str { > + match self { > + Resource::PveStorage(r) => r.status.as_str(), > + Resource::PveQemu(r) => r.status.as_str(), > + Resource::PveLxc(r) => r.status.as_str(), > + Resource::PveNode(r) => r.status.as_str(), > + Resource::PbsNode(r) => { > + if r.uptime > 0 { > + "online" > + } else { > + "offline" > + } > + } > + Resource::PbsDatastore(_) => "online", > + } > + } > } > > #[api( > -- > 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel