Re: [PATCH datacenter-manager v2 1/4] api: return global cpu/memory/storage statistics

Lukas Wagner
2026-04-02T13:47:38Z

On Thu Apr 2, 2026 at 3:02 PM CEST, Dominik Csapak wrote:
>>> +#[api]
>>> +#[derive(Default, Serialize, Deserialize, Clone, PartialEq)]
>>> +/// Statistics for CPU utilization
>>> +pub struct CpuStatistics {
>>> + /// Amount of threads utilized
>>
>> 'thread' is a countable noun, so it should rather be "Number of threads"
>
> thanks, i'll fix it, but just to note, in that same file we have
> many instances of this, for example:
>
> "Amount of running guests"
> "Amount of online datastores"
> "Amount of configured remotes"
>
>
> which all seem to me like countable nouns?
>
> so we might want to clean that up for all of them

Yeah, this would make sense! Feel free to include it as a separate patch
in this series :)