From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 60A8F1FF15E for ; Mon, 24 Nov 2025 11:33:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 437461EE44; Mon, 24 Nov 2025 11:33:14 +0100 (CET) Message-ID: Date: Mon, 24 Nov 2025 11:32:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Shannon Sterz References: <20251117125041.1931382-1-d.csapak@proxmox.com> <20251117125041.1931382-9-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763980324889 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rust-lang.org] Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 08/18] ui: dashboard: prepare view for editing custom views X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 11/17/25 3:58 PM, Shannon Sterz wrote: > comments in-line. > > On Mon Nov 17, 2025 at 1:44 PM CET, Dominik Csapak wrote: [snip] >> } >> None => {} >> } >> @@ -490,6 +517,7 @@ async fn load_template() -> Result { >> \"leaderboard-type\": \"node-memory\" >> } >> ], >> + [], > > this is removed again in the very next commit (it's masked a bit because > of an indent change). is this intentional? no, this slipped in at some point i guess, i'll remove it > >> [ >> { >> \"flex\": 5.0, >> diff --git a/ui/src/dashboard/view/row_element.rs b/ui/src/dashboard/view/row_element.rs >> new file mode 100644 >> index 00000000..d242195c >> --- /dev/null >> +++ b/ui/src/dashboard/view/row_element.rs >> @@ -0,0 +1,130 @@ >> +use yew::html::IntoEventCallback; >> + >> +use pwt::css; >> +use pwt::prelude::*; >> +use pwt::props::RenderFn; >> +use pwt::widget::{ActionIcon, Card, Fa, Panel, Row}; >> +use pwt_macros::{builder, widget}; >> + >> +use crate::dashboard::types::RowWidget; >> + >> +#[widget(comp=RowElementComp, @element)] >> +#[derive(PartialEq, Properties, Clone)] >> +#[builder] >> +pub struct RowElement { >> + item: RowWidget, >> + widget_renderer: RenderFn, >> + >> + #[builder] >> + #[prop_or_default] >> + edit_mode: bool, >> + >> + #[builder] >> + #[prop_or_default] >> + is_dragging: bool, >> + >> + #[builder_cb(IntoEventCallback, into_event_callback, ())] >> + #[prop_or_default] >> + on_remove: Option>, >> + >> + #[builder_cb(IntoEventCallback, into_event_callback, u32)] >> + #[prop_or_default] >> + on_flex_change: Option>, >> +} >> + >> +impl RowElement { >> + pub fn new(item: RowWidget, widget_renderer: impl Into>) -> Self { >> + let widget_renderer = widget_renderer.into(); >> + yew::props!(Self { >> + item, >> + widget_renderer >> + }) >> + } >> +} >> + >> +pub enum Msg { > > is this `pub` intentionally? yes, an associated type of a public trait must also be public, see e.g. this example that does not compile: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=29cd3ee5b2d1d0ca090e1c394c03b40a > [snip] >> +pub enum Msg { >> + DragEvent(DragMsg), >> + AddRow, >> + RemoveRow(usize), // idx >> + EditFlex(Position, u32), >> + AddWidget(Position, WidgetType), >> + RemoveWidget(Position), >> + MoveRow(usize, MoveDirection), // idx >> + HandleEditMessages, >> +} > > are these intentionally `pub`? same here _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel