From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3D4341FF136 for ; Mon, 09 Mar 2026 21:05:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E9F23982F; Mon, 9 Mar 2026 21:05:27 +0100 (CET) Message-ID: Date: Mon, 9 Mar 2026 21:05:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox 1/4] fix #7315: generate: add support for new certificate variant To: Lukas Sichert , pdm-devel@lists.proxmox.com References: <20260302134537.108696-1-l.sichert@proxmox.com> <20260302134537.108696-2-l.sichert@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260302134537.108696-2-l.sichert@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773086691481 X-SPAM-LEVEL: Spam detection results: 0 AWL -2.583 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [types.rs] Message-ID-Hash: UFMBAFJEBCM5D4CTYUL4U4YLWTYX4JA6 X-Message-ID-Hash: UFMBAFJEBCM5D4CTYUL4U4YLWTYX4JA6 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: no biggie, but subject would be IMO slightly nicer if written as: pve-api-types: vm config: add support for new OVMF MS cert variant while that is a bit condensed, it still gives me much more context about what's touched here. Am 02.03.26 um 14:45 schrieb Lukas Sichert: > Since the last time the types.rs has been generated a new Windows > certificate variant was added. As no mapping for this variant to a rust > enum exits, generating the types fails. > > To add support for this variant, add a mapping from the Perl definition > to a Rust enum. > > Signed-off-by: Lukas Sichert > --- > pve-api-types/generate.pl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/pve-api-types/generate.pl b/pve-api-types/generate.pl > index e5c5d051..ba732e9d 100755 > --- a/pve-api-types/generate.pl > +++ b/pve-api-types/generate.pl > @@ -94,6 +94,7 @@ Schema2Rust::register_enum_variant('QemuConfigEfidisk0Efitype::2m' => 'Mb2'); > Schema2Rust::register_enum_variant('QemuConfigEfidisk0Efitype::4m' => 'Mb4'); > Schema2Rust::register_enum_variant('QemuConfigEfidisk0MsCert::2011' => 'CA2011'); > Schema2Rust::register_enum_variant('QemuConfigEfidisk0MsCert::2023' => 'CA2023'); > +Schema2Rust::register_enum_variant('QemuConfigEfidisk0MsCert::2023w' => 'CA2023w'); > Schema2Rust::register_enum_variant('QemuConfigHugepages::2' => 'Mb2'); > Schema2Rust::register_enum_variant('QemuConfigHugepages::1024' => 'Mb1024'); > Schema2Rust::register_enum_variant('PveQmRngSource::/dev/urandom', => 'DevUrandom');