From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id C5F891FF170
	for <inbox@lore.proxmox.com>; Thu, 15 May 2025 09:05:08 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 1C1401B174;
	Thu, 15 May 2025 09:05:32 +0200 (CEST)
Message-ID: <ab7aaf4b-97a0-4516-b97e-fd69fcb09118@proxmox.com>
Date: Thu, 15 May 2025 09:05:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: pdm-devel@lists.proxmox.com
References: <20250512114144.118545-1-l.wagner@proxmox.com>
 <20250512114144.118545-7-l.wagner@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20250512114144.118545-7-l.wagner@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.022 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v5 6/6] fake
 remote: clippy fixes
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>


Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 5/12/25 13:41, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> 
> Notes:
>      Added in v3
> 
>   server/src/test_support/fake_remote.rs | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/server/src/test_support/fake_remote.rs b/server/src/test_support/fake_remote.rs
> index ae0f0af1..27ba7c5c 100644
> --- a/server/src/test_support/fake_remote.rs
> +++ b/server/src/test_support/fake_remote.rs
> @@ -1,4 +1,4 @@
> -use std::{collections::HashMap, sync::Arc, time::Duration};
> +use std::{sync::Arc, time::Duration};
>   
>   use anyhow::{bail, Error};
>   use serde::Deserialize;
> @@ -129,7 +129,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
>           let mut vmid = 100;
>   
>           for _ in 0..self.nr_of_vms {
> -            vmid = vmid + 1;
> +            vmid += 1;
>               result.push(ClusterResource {
>                   cgroup_mode: None,
>                   content: None,
> @@ -162,7 +162,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
>           }
>   
>           for _ in 0..self.nr_of_cts {
> -            vmid = vmid + 1;
> +            vmid += 1;
>               result.push(ClusterResource {
>                   cgroup_mode: None,
>                   content: None,
> @@ -354,7 +354,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
>       async fn list_nodes(&self) -> Result<Vec<ClusterNodeIndexResponse>, proxmox_client::Error> {
>           tokio::time::sleep(Duration::from_millis(self.api_delay_ms as u64)).await;
>           Ok((0..self.nr_of_nodes)
> -            .into_iter()
>               .map(|i| ClusterNodeIndexResponse {
>                   node: format!("pve-{i}"),
>                   cpu: None,
> @@ -411,7 +410,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
>           let number_of_tasks = limit.min(number_of_tasks as u64);
>   
>           Ok((0..number_of_tasks)
> -            .into_iter()
>               .map(|i| make_task(now - i as i64 * NEW_TASK_EVERY * 60))
>               .collect())
>       }



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel