From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AD1291FF139 for ; Tue, 24 Feb 2026 14:41:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08666B7B4; Tue, 24 Feb 2026 14:42:50 +0100 (CET) Message-ID: Date: Tue, 24 Feb 2026 14:42:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH datacenter-manager v2 0/2] improvements for ParallelFetcher To: Lukas Wagner , pdm-devel@lists.proxmox.com References: <20260206094304.117465-1-l.wagner@proxmox.com> Content-Language: en-US From: Lukas Sichert In-Reply-To: <20260206094304.117465-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771940518874 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.167 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SQLX7RS7EZDGVONZPMGXSBMLE3WYNJCX X-Message-ID-Hash: SQLX7RS7EZDGVONZPMGXSBMLE3WYNJCX X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The changes were reviewed and tested in a cluster consisting of two PVE nodes and one PBS. The following features were considered for testing: Update handling: The update summary could be retrieved without issues. Tasks: The task log was displayed correctly. Only for the cluster: SDN: A Simple Zone and an EVPN Zone were created. Both zones and the EVPN Controller were displayed correctly. Firewall: Node firewall rules and datacenter firewall configuration were shown correctly. The tests were also repeated with one of the nodes offline, and everything still worked as expected. While reviewing the code, I noticed that the async fetchers currently have no explicit timeouts. If one of the fetch operations blocks indefinitely, it could stall the overall execution. Adding this in a future commit would improve robustness. Reviewed-by: Lukas Sichert Tested-by: Lukas Sichert On 2/6/26 10:41, Lukas Wagner wrote: > A couple of improvents for the parallel_fetcher module: > - inherit log context so that logging in worker tasks works > - response type improvements, better ergonomics for callers > - documentation > > Changes since v2: > - Change type names from *Outcome to *Response > > > proxmox-datacenter-manager: > > Lukas Wagner (2): > parallel fetcher: improve result type ergonomics > parallel fetcher: add module documentation > > server/src/api/pve/firewall.rs | 53 +-- > server/src/api/sdn/controllers.rs | 38 +- > server/src/api/sdn/vnets.rs | 35 +- > server/src/api/sdn/zones.rs | 35 +- > .../tasks/remote_tasks.rs | 33 +- > server/src/parallel_fetcher.rs | 333 +++++++++++++----- > server/src/remote_updates.rs | 36 +- > 7 files changed, 340 insertions(+), 223 deletions(-) > > > Summary over all repositories: > 7 files changed, 340 insertions(+), 223 deletions(-) >