From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4039A1FF187 for ; Mon, 25 Aug 2025 11:54:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ED499E41B; Mon, 25 Aug 2025 11:54:39 +0200 (CEST) Message-ID: Date: Mon, 25 Aug 2025 11:54:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Datacenter Manager development discussion , Dominik Csapak References: <20250825081042.797559-1-d.csapak@proxmox.com> <20250825081042.797559-6-d.csapak@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20250825081042.797559-6-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.711 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 5/8] ui: tasks: add helper to summarize task categories X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 8/25/25 10:10 AM, Dominik Csapak wrote: > one for mapping UPID worker types to shortahnds that can be used for > pre-filtering via the api (have to filter on the client side a bit more > since we'll return more than what we want with the current filtering > api) > > and one for creating a title for each type > > Signed-off-by: Dominik Csapak > --- > ui/src/tasks.rs | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/ui/src/tasks.rs b/ui/src/tasks.rs > index 0e7899c..a94cc9a 100644 > --- a/ui/src/tasks.rs > +++ b/ui/src/tasks.rs > @@ -120,3 +120,32 @@ pub fn format_optional_remote_upid(upid: &str, include_remote: bool) -> String { > format_upid(&upid) > } > } > + > +/// Map worker types to sensible categories (that can also be used as filter for the api) > +/// > +/// Note: if using as filter for the api, the result has to be filtered with this again, since > +/// more records will be returned. E.g. using 'vz' will also return 'vzdump' tasks which are > +/// not desired. > +pub fn map_worker_type(worker_type: &str) -> &str { > + match worker_type { > + task_type if task_type.contains("migrate") => "migrate", > + task_type if task_type.starts_with("qm") => "qm", > + task_type if task_type.starts_with("vz") && task_type != "vzdump" => "vz", > + task_type if task_type.starts_with("ceph") => "ceph", > + task_type if task_type.starts_with("ha") => "ha", > + other => other, > + } > +} > + > +/// Map a category from [`map_worker_type`] to a title text. > +pub fn get_type_title(task_type: &str) -> String { > + match task_type { > + "migrate" => tr!("Guest Migrations"), > + "qm" => tr!("Virtual Machine related Tasks"), > + "vz" => tr!("Container related Tasks"), > + "ceph" => tr!("Ceph related Tasks"), > + "vzdump" => tr!("Backup Tasks"), > + "ha" => tr!("HA related Tasks"), > + other => other.to_string(), > + } > +} maybe better suited as an enum with FromStr(or From<_> since it's infallible) + Display? _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel