From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 744B81FF17C for ; Wed, 20 Aug 2025 13:58:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 226F399AC; Wed, 20 Aug 2025 13:59:59 +0200 (CEST) Message-ID: Date: Wed, 20 Aug 2025 13:59:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pdm-devel@lists.proxmox.com References: <20250820084726.51170-1-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20250820084726.51170-1-s.hanreich@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.705 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox-yew-widget-toolkit v2 1/1] data table: add get_property helper for displaying optional values X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" rather, obsoleted by: https://lore.proxmox.com/pdm-devel/20250820115809.196115-1-s.hanreich@proxmox.com/T/#u On 8/20/25 10:46 AM, Stefan Hanreich wrote: > In some cases, particularly for tree views, it might make sense to not > show values for some cells. In order to simplify handling optional > values, add two get_property helpers that can work with optional > values. It renders the values if it exists and nothing otherwise. > Since Option implements Ord, the widget can use its Ord implementation > for sorting. The current helpers cannot be used, since Option does not > implement Display, so the trait bounds are not satisfied. Analogous to > the existing helpers, add one for owned values and one for references. > > Signed-off-by: Stefan Hanreich > --- > > Notes: > Changes from v1: > * add helper for owned values as well > > src/widget/data_table/column.rs | 36 ++++++++++++++++++++++++++++++++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/src/widget/data_table/column.rs b/src/widget/data_table/column.rs > index 016be99..6cd8e1b 100644 > --- a/src/widget/data_table/column.rs > +++ b/src/widget/data_table/column.rs > @@ -5,7 +5,7 @@ use derivative::Derivative; > use yew::html::IntoPropValue; > use yew::prelude::*; > > -use yew::virtual_dom::Key; > +use yew::virtual_dom::{Key, VNode}; > > use crate::props::{CallbackMut, IntoEventCallbackMut, IntoSorterFn, RenderFn, SorterFn}; > use crate::state::TreeStore; > @@ -328,6 +328,40 @@ impl DataTableColumn { > .render(move |item: &T| html! {{get_property_fn(item)}}) > } > > + /// Builder style method to set a get_property_fn for renderer and sorter > + /// the given fn must return the value as an Option containing a reference. > + pub fn get_property_optional( > + self, > + get_property_fn: impl 'static + Fn(&T) -> Option<&E>, > + ) -> Self { > + let get_property_fn = Rc::new(get_property_fn); > + self.sorter({ > + let get_property_fn = get_property_fn.clone(); > + move |itema: &T, itemb: &T| get_property_fn(itema).cmp(&get_property_fn(itemb)) > + }) > + .render( > + move |item: &T| html! {{get_property_fn(item).map(VNode::from).unwrap_or_default()}}, > + ) > + } > + > + /// Builder style method to set a get_property_fn for renderer and sorter > + /// the given fn must return the value as an Option containing an owned value. > + /// NOTE: on sort this will be called multiple times per entry, so use with caution for large > + /// lists. > + pub fn get_property_optional_owned( > + self, > + get_property_fn: impl 'static + Fn(&T) -> Option, > + ) -> Self { > + let get_property_fn = Rc::new(get_property_fn); > + self.sorter({ > + let get_property_fn = get_property_fn.clone(); > + move |itema: &T, itemb: &T| get_property_fn(itema).cmp(&get_property_fn(itemb)) > + }) > + .render( > + move |item: &T| html! {{get_property_fn(item).map(VNode::from).unwrap_or_default()}}, > + ) > + } > + > /// Builder style method for [`Self::set_tree_column`] > pub fn tree_column(mut self, store: impl IntoPropValue>>) -> Self { > self.set_tree_column(store); _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel