From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5FE691FF0E1 for ; Mon, 10 Aug 2026 15:23:42 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 38ED321762; Mon, 10 Aug 2026 15:23:41 +0200 (CEST) Message-ID: Date: Mon, 10 Aug 2026 15:23:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{-backup,-datacenter-manager} 0/2] fix #7746: cli: show installed instead of candidate version To: Erik Fastermann , pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com References: <20260727135940.267321-1-e.fastermann@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260727135940.267321-1-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786368205344 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.876 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BBMLTPTKQHOXYSH2Z2KDKDDZBJSZBXJP X-Message-ID-Hash: BBMLTPTKQHOXYSH2Z2KDKDDZBJSZBXJP X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/27/26 3:59 PM, Erik Fastermann wrote: > The change is identical for PBS and PDM, see the commit messages for > the rationale. Could make sense to share some of this code with a > future refactor. Thanks for the patches, changes look good to me and fix the issue. API already provides the correct information and remains untouched so localized to the manager output and system report, where now the intended information is shown. Reviewed-by: Christian Ebne Tested-by: Christian Ebne