From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>,
<pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox 2/6] fix #6081: log: replace simple level filter with env filter
Date: Mon, 12 Oct 2026 14:16:22 +0200 [thread overview]
Message-ID: <DM2UPFZ5LT1H.3IP8PH152ST6A@proxmox.com> (raw)
In-Reply-To: <20261007074527.102419-3-t.ellmenreich@proxmox.com>
On Wed Oct 7, 2026 at 9:45 AM CEST, Thomas Ellmenreich wrote:
> Instead of parsing the contents of the environment variable passed to the
> Logger as a simple LevelFilter, parse them as an EnvFilter [0]. This is
> backwards compatible, as a simple LevelFilter [1] string is parsable as
> an EnvFilter.
>
> [0]: https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html
> [1]: https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.LevelFilter.html
>
> Suggested-by: Gabriel Goller <g.goller@proxmox.com>
> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6081
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
next prev parent reply other threads:[~2026-10-12 12:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 7:45 [PATCH datacenter-manager/proxmox 0/6] log: allow finegrained control logging levels Thomas Ellmenreich
2026-10-07 7:45 ` [PATCH proxmox 1/6] log: replace per layer filtering by one global filter Thomas Ellmenreich
2026-10-12 12:16 ` Lukas Wagner
2026-10-12 13:20 ` Gabriel Goller
2026-10-07 7:45 ` [PATCH proxmox 2/6] fix #6081: log: replace simple level filter with env filter Thomas Ellmenreich
2026-10-12 12:16 ` Lukas Wagner [this message]
2026-10-07 7:45 ` [PATCH proxmox 3/6] log: cleanup of logger components Thomas Ellmenreich
2026-10-12 12:16 ` Lukas Wagner
2026-10-07 7:45 ` [PATCH proxmox 4/6] log: add tests to the logger Thomas Ellmenreich
2026-10-12 12:16 ` Lukas Wagner
2026-10-07 7:45 ` [PATCH datacenter-manager 5/6] api: set REST server debug level based on actual log level Thomas Ellmenreich
2026-10-12 12:16 ` Lukas Wagner
2026-10-07 7:45 ` [PATCH datacenter-manager 6/6] api: update logging variable Thomas Ellmenreich
2026-10-12 12:15 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM2UPFZ5LT1H.3IP8PH152ST6A@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=t.ellmenreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox