public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method
Date: Fri, 02 Oct 2026 14:12:03 +0200	[thread overview]
Message-ID: <DLUCCOZVUTTL.1M1PESDH6YDLA@proxmox.com> (raw)
In-Reply-To: <20260622120658.361868-1-s.shaji@proxmox.com>

gentle ping, this still applies.

On Mon Jun 22, 2026 at 2:06 PM CEST, Shan Shaji wrote:
> If the inet6 address family's cidr6/gatway6 values are not present, the
> interface.method6 values is mutated with `NetworkConfigMethod::Manual`
> even if the interface.method6 already has a value. For example, if
> the config method is `auto` then it gets replaced by `Manual` config
> method.
>
> Later, when writing the config file to the interfaces.new file if the
> config method is manual and if there are no IPv6 specific attributes
> present, then the inet6 stanza gets skipped.
>
> In order to fix the issue update the condition to only set the config
> method to `::Manual` if there is no value present inside the `method6`
> property of the interface object.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
>  note: The issue where the UI showed an error has already been fixed
>  in commit (#973cf333).
>
>  proxmox-network-api/src/api_impl.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-network-api/src/api_impl.rs b/proxmox-network-api/src/api_impl.rs
> index 9d956e2c..ee78a88c 100644
> --- a/proxmox-network-api/src/api_impl.rs
> +++ b/proxmox-network-api/src/api_impl.rs
> @@ -332,7 +332,7 @@ pub fn update_interface(
>
>      if interface.cidr6.is_some() || interface.gateway6.is_some() {
>          interface.method6 = Some(NetworkConfigMethod::Static);
> -    } else {
> +    } else if interface.method6.is_none() {
>          interface.method6 = Some(NetworkConfigMethod::Manual);
>      }
>





      reply	other threads:[~2026-10-02 12:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 12:06 [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method Shan Shaji
2026-10-02 12:12 ` Shan Shaji [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLUCCOZVUTTL.1M1PESDH6YDLA@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal