public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Erik Fastermann" <e.fastermann@proxmox.com>,
	<pbs-devel@lists.proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: applied: [PATCH proxmox-datacenter-manager v2 2/2] fix #7746: cli: admin: show installed instead of candidate version
Date: Fri, 02 Oct 2026 10:48:48 +0200	[thread overview]
Message-ID: <DLU812HWWVX0.HRFYLQE7DI0V@proxmox.com> (raw)
In-Reply-To: <20261002071000.131772-3-e.fastermann@proxmox.com>

On Fri Oct 2, 2026 at 9:10 AM CEST, Erik Fastermann wrote:
> The 'versions' command printed 'Version' from the API result, which
> carries the version apt would upgrade to, not the one that is
> installed. Whenever the apt cache knows a newer version, the command
> therefore reported a version that is not installed at all, and the
> output changed after a plain 'apt update'. This also affects the
> 'report' command, which runs 'versions --verbose'.
>
> The installed version is available as 'OldVersion', which is what the
> GUI reads as well. The name is unfortunate for a listing of installed
> packages, but as far as I can tell every other consumer uses it
> correctly. The only exceptions were this command and its equivalent in
> Proxmox Backup Server, which is fixed in a separate patch.
>
> Use a renderer for the column, as 'OldVersion' is not set for packages
> that are not installed, where the table would otherwise show an empty
> cell instead of 'unknown', matching the previous behavior.
>
> The header is not shown while 'noborder' is set, as the table formatter
> then suppresses headers as well. Still label it 'Version' rather than
> 'Old Version', as from the user's point of view it is the current
> version, and the label stays correct should the borders ever be enabled.
>
> The naming is inherited from PVE, where the same record is used for
> both the available updates and the installed package listing. Giving
> the versions endpoint its own type would avoid the trap for future
> callers, but that is a more complex API change and can be done in a
> future commit.
>
> Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
> Tested-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>

applied the PDM patch, thanks!




      reply	other threads:[~2026-10-02  8:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  7:09 [PATCH proxmox{-backup,-datacenter-manager} v2 0/2] fix #7746: cli: show installed instead of candidate version Erik Fastermann
2026-10-02  7:09 ` [PATCH proxmox-backup v2 1/2] fix #7746: cli: manager: " Erik Fastermann
2026-10-02  7:10 ` [PATCH proxmox-datacenter-manager v2 2/2] fix #7746: cli: admin: " Erik Fastermann
2026-10-02  8:48   ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLU812HWWVX0.HRFYLQE7DI0V@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=e.fastermann@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal