Re: [PATCH datacenter-manager 5/5] api: set REST server debug level based on actual log level

["Thomas Ellmenreich" <t.ellmenreich@proxmox.com>]

On Mon Sep 21, 2026 at 11:51 AM CEST, Thomas Ellmenreich wrote:
> Use the configuration returned by the initialised logger to decide whether to
> activate debugging for the REST server.
>
> Previously, whether the REST server was in debug mode would only be determined
> by the existence of the PROXMOX_DEBUG variable, regardless of its value. Now,
> if the environment variable is set to a less verbose level than 'debug', the
> REST server will not activate its debug level.
>
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  server/src/bin/proxmox-datacenter-api/main.rs | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/server/src/bin/proxmox-datacenter-api/main.rs b/server/src/bin/proxmox-datacenter-api/main.rs
> index 57aa6e22..7b2d85cb 100644
> --- a/server/src/bin/proxmox-datacenter-api/main.rs
> +++ b/server/src/bin/proxmox-datacenter-api/main.rs
> @@ -46,13 +46,15 @@ fn main() -> Result<(), Error> {
>  
>      server::env::sanitize_environment_vars();
>  
> -    let debug = std::env::var("PROXMOX_DEBUG").is_ok();
> -
> -    proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO)
> +    let log_config = proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO)
>          .journald_on_no_workertask()
>          .tasklog_pbs()
>          .init()?;
>  
> +    // NOTE: this will now also activate if a very specific module is set
> +    // to debug but the default level is still on info
> +    let debug = log_config.global_filter_max_level_hint() >= LevelFilter::DEBUG;

After working on another issue, I realised that the entire LoggerConfig part
could be removed and replaced with a simple 'proxmox_log::enabled!', which
would look like this:

```
let debug = proxmox_log::enabled!(LevelFilter::DEBUG);
```

This is cleaner and also removes the LoggerConfig, that is not really
needed outside of this single instance.

> +
>      if std::env::args().nth(1).is_some() {
>          bail!("unexpected command line parameters");
>      }