From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Christoph Heiss" <c.heiss@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH installer v2 09/16] post-hook: support creating API token if requested in answer file
Date: Thu, 10 Sep 2026 15:42:12 +0200 [thread overview]
Message-ID: <DLBOHQ6H9066.14JD89VI2O8AV@proxmox.com> (raw)
In-Reply-To: <20260826110504.1339934-10-c.heiss@proxmox.com>
On Wed Aug 26, 2026 at 1:04 PM CEST, Christoph Heiss wrote:
[snip]
> diff --git a/Cargo.toml b/Cargo.toml
> index a134ffb..55d2192 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -28,12 +28,14 @@ serde_plain = "1.0"
> sha2 = "0.10"
> toml = "0.8"
> proxmox-auto-installer.path = "./proxmox-auto-installer"
> -proxmox-installer-common.path = "./proxmox-installer-common"
> proxmox-network-types = "1.1"
> +proxmox-installer-common.path = "./proxmox-installer-common"
> proxmox-installer-types = { version = "0.1.1", features = ["legacy"] }
^
Should this version not be bumped to 0.2? I could not find
a series that does this. (Although it can definitely be that
I have missed it).
> +proxmox-time = "2.1"
[snip]
next prev parent reply other threads:[~2026-09-10 13:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 11:04 [PATCH datacenter-manager/installer/proxmox v2 00/16] auto-installer: add installed target systems as new remotes Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 01/16] installer-types: drop unnecessary clippy attribute Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 02/16] installer-types: post-hook: factor schema version into proper struct Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 03/16] installer-types: post-hook: allow additional properties on api schema Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 04/16] installer-types: post-hook: add api-token and cert-fingerprint options Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 05/16] installer-types: systeminfo: add check for API token creation capability Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 06/16] chroot: print full error if bind-mounting fails Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 07/16] post-hook: re-use low-level config retrieval from proxmox-chroot Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 08/16] post-hook: generate and retrieve node certificate fingerprint Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 09/16] post-hook: support creating API token if requested in answer file Christoph Heiss
2026-09-10 13:42 ` Thomas Ellmenreich [this message]
2026-08-26 11:04 ` [PATCH installer v2 10/16] auto: enforce https for post hook when generating an API token Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 11/16] assistant: validate-answer: also verify post-hook settings if set Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 12/16] ui: auto-installer: spell out Proxmox Datacenter Manager Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 13/16] config: auto-install: add optional `post-hook-add-as-remote` field Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 14/16] api: auto-installer: add option for adding new remotes to PDM Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 15/16] ui: auto-installer: wizard: add checkbox to add target as new remote Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 16/16] docs: auto-installer: document adding targets as remotes afterwards Christoph Heiss
2026-08-28 11:47 ` [PATCH datacenter-manager/installer/proxmox v2 00/16] auto-installer: add installed target systems as new remotes Christoph Heiss
2026-09-10 13:53 ` Thomas Ellmenreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLBOHQ6H9066.14JD89VI2O8AV@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox