Re: [PATCH proxmox v5 03/21] api-macro: support #[state] attribute for state injection

["Michael Köppl" <m.koeppl@proxmox.com>]

On Thu Sep 3, 2026 at 1:15 PM CEST, Lukas Wagner wrote:

[snip]

>  fn handle_function_signature(method_info: &mut MethodInfo) -> Result<Ident, Error> {
> +    let state_params = take_state_attributes(&mut method_info.func.sig);
> +
>      let sig = &method_info.func.sig;
>  
>      let mut api_method_param = None;
> @@ -382,7 +474,11 @@ fn handle_function_signature(method_info: &mut MethodInfo) -> Result<Ident, Erro
>  
>      let mut param_list = Vec::<(FieldName, ParameterType)>::new();
>  
> -    for input in sig.inputs.iter() {
> +    for (index, input) in sig.inputs.iter().enumerate() {
> +        if state_params.contains(&index) {
> +            continue;
> +        }

Even though it's not something that would likely occur (since this would
e.g. occur if someone used `#[state] _: PdmApplication` or something
similar), this would not show any errors from checking the types
anymore, no? Because the second [loop] expects errors to be handled
[here], but for state params, this check would simply be skipped. Hope
I'm not missing something here, but this would probably hide errors.

> +
>          let (pat_type, pat) = match check_input_type(input) {
>              Ok(input) => input,
>              Err(err) => {

[here]

> @@ -410,7 +506,7 @@ fn handle_function_signature(method_info: &mut MethodInfo) -> Result<Ident, Erro
>          };
>      }
>  
> -    for input in sig.inputs.iter() {
> +    for (index, input) in sig.inputs.iter().enumerate() {
>          let (pat_type, pat) = match check_input_type(input) {
>              Ok(input) => input,
>              Err(_err) => continue, // we already produced errors above,

[loop]

> @@ -421,17 +517,20 @@ fn handle_function_signature(method_info: &mut MethodInfo) -> Result<Ident, Erro
>          // values, and our 2 fixed function parameters: `&ApiMethod` and `&mut dyn RpcEnvironment`.
>          //
>          // Our strategy is as follows:
> -        //     1) See if the parameter name also appears in the input schema. In this case we
> +        //     1) See if the parameter was marked with `#[state]`. Such parameters are filled in

[snip]