From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A03331FF09B for ; Mon, 31 Aug 2026 13:26:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 70228212BA; Mon, 31 Aug 2026 13:26:09 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 31 Aug 2026 13:26:04 +0200 Message-Id: Subject: applied: [PATCH datacenter-manager 0/2] Remove running tasks from From: "Lukas Wagner" To: "Jonas Theisen" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260828155110.563237-1-j.theisen@proxmox.com> In-Reply-To: <20260828155110.563237-1-j.theisen@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788175551046 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.951 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_DBL_SPAM 5 Contains a spam URL listed in the Spamhaus DBL blocklist [tasks.rs] Message-ID-Hash: EXEPKRKJBZMMIXMGJRLCGOVUZHTLZOKY X-Message-ID-Hash: EXEPKRKJBZMMIXMGJRLCGOVUZHTLZOKY X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Aug 28, 2026 at 5:49 PM CEST, Jonas Theisen wrote: > This patch series fixes issues with filtering for errored tasks > where running tasks would get wrongly displayed or returned through > the API. > > The first patch is analogous to the patch suggested for PBS in [1] > and fixes the PDM local tasks returned by the API when queried for > errors. > > The second patch was added to align the behavior of tasks imported > from PVE to the tasks from PBS or returned by PDM. > This indirectly also fixes the issue that running PVE tasks get > displayed in the Remote tab of PDM when filtering for errors > while running PBS tasks got correctly filtered out. > > [1] https://lore.proxmox.com/pbs-devel/20260827154740.427154-1-j.theisen@= proxmox.com/ > > Jonas Theisen (2): > api: Remove running tasks from errors output > remote-tasks: Align fetched PVE tasks to PBS and PDM API > > server/src/api/nodes/tasks.rs | 1 + > server/src/remote_tasks/refresh_task.rs | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletion(-) applied, thanks! I slightly touched up the commit messages, but nothing major. I also directly followed up with a patch for the remote-tasks API. While you fixed the discrepancies between PBS and PVE tasks, you forgot to add the additional condition to the remote-tasks API, so running tasks where still included in the API response when `errors` as set. https://git.proxmox.com/?p=3Dproxmox-datacenter-manager.git;a=3Dcommitdiff;= h=3Dc3ca3a8179164d9773cc67cbe1a7e821ec80666c