Re: [PATCH datacenter-manager] ui: auto-installer: allow multi-select of installation entries

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Aug 27, 2026 at 2:40 PM CEST, Christoph Heiss wrote:
> Depending on the environment/usage, a lot of entries of past
> installations can accumulate here over time.
>
> Having the possibility for bulk deletion makes it easier to deal with
> this.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>

Hi, thanks for the patch!

I think the UX could be improved a bit. Right now, it's a bit weird that
*any* click on the row automatically selects it. For instance, when
going through entries one by one to show the "System Information", this
is a bit annoying, since one cannot press the 'System Information'
button if multiple entries are selected.

I think this could be solved in two ways:

  - Require the user to explicitly enable 'bulk-select', e.g. by
    pressing a button or ticking a check-box in the header. Before doing
    so, the checkbox column could be hidden

  - Patch 'DataTable' so that only a click on the checkbox selects the
    entry, but not when clicking anywhere else. This probably needs to
    be configurable, not sure if we don't break other UIs if we do that.


I think the first option could be the preferable one.


> ---
>  .../auto_installer/installations_panel.rs     | 38 +++++++++++--------
>  1 file changed, 23 insertions(+), 15 deletions(-)
>
> diff --git a/ui/src/remotes/auto_installer/installations_panel.rs b/ui/src/remotes/auto_installer/installations_panel.rs
> index 2bb52278..c40628e8 100644
> --- a/ui/src/remotes/auto_installer/installations_panel.rs
> +++ b/ui/src/remotes/auto_installer/installations_panel.rs
> @@ -22,7 +22,7 @@ use pwt::{
>      tr,
>      widget::{
>          Button, Toolbar,
> -        data_table::{DataTable, DataTableColumn, DataTableHeader},
> +        data_table::{DataTable, DataTableColumn, DataTableHeader, MultiSelectMode},
>          form::TextArea,
>      },
>  };
> @@ -77,8 +77,9 @@ impl LoadableComponent for InstallationsPanelComponent {
>      type ViewState = ViewState;
>  
>      fn create(ctx: &LoadableComponentContext<Self>) -> Self {
> -        let selection =
> -            Selection::new().on_select(ctx.link().callback(|_| Message::SelectionChange));
> +        let selection = Selection::new()
> +            .multiselect(true)
> +            .on_select(ctx.link().callback(|_| Message::SelectionChange));
>  
>          let store =
>              Store::with_extract_key(|record: &Installation| Key::from(record.uuid.to_string()));
> @@ -112,15 +113,18 @@ impl LoadableComponent for InstallationsPanelComponent {
>              }
>              Self::Message::SelectionChange => true,
>              Self::Message::RemoveEntry => {
> -                if let Some(key) = self.selection.selected_key() {
> +                self.spawn({
>                      let link = ctx.link().clone();
> -                    self.spawn(async move {
> -                        if let Err(err) = delete_entry(key).await {
> -                            link.show_error(tr!("Unable to delete entry"), err, true);
> +                    let selection = self.selection.clone();
> +                    async move {
> +                        for key in selection.selected_keys() {
> +                            if let Err(err) = delete_entry(key).await {
> +                                link.show_error(tr!("Unable to delete entry {key}"), err, true);
> +                            }
>                          }

I guess in most cases a 'bulk-remove' API endpoint is preferable, mostly
to at least *enable* atomicity at the API level. But since removing
installations ends up removing individual files any way, which is
inherently not atomic, I guess the current approach is fine as well.

If we ever end up storing installations in something that supports
atomic operations (say, a sqlite DB or a single JSON file), a
bulk-delete endpoint can be added as well.

>                          link.send_reload();
> -                    })
> -                }
> +                    }
> +                });
>                  false
>              }
>          }