From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 704CE1FF0C1 for ; Wed, 26 Aug 2026 15:12:51 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BFA6C21326; Wed, 26 Aug 2026 15:12:50 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 26 Aug 2026 15:12:47 +0200 Message-Id: To: "Lukas Wagner" , Subject: Re: [PATCH proxmox v2 01/20] router: introduce shared state From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.22.0 References: <20260820145220.418032-1-l.wagner@proxmox.com> <20260820145220.418032-2-l.wagner@proxmox.com> In-Reply-To: <20260820145220.418032-2-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787749959367 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.011 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DXQ7FNKUZZZVZWUK5SC6IWTAXVO5ZI53 X-Message-ID-Hash: DXQ7FNKUZZZVZWUK5SC6IWTAXVO5ZI53 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Aug 20, 2026 at 4:52 PM CEST, Lukas Wagner wrote: [snip] > diff --git a/proxmox-router/src/lib.rs b/proxmox-router/src/lib.rs > index da2f018f..df225d25 100644 > --- a/proxmox-router/src/lib.rs > +++ b/proxmox-router/src/lib.rs > @@ -16,6 +16,7 @@ mod permission; > mod router; > mod rpc_environment; > mod serializable_return; > +mod shared_state; > =20 > #[doc(inline)] > #[cfg(feature =3D "server")] > @@ -25,6 +26,7 @@ pub use permission::*; > pub use router::*; > pub use rpc_environment::{RpcEnvironment, RpcEnvironmentType}; > pub use serializable_return::SerializableReturn; > +pub use shared_state::{SharedStateRegistry, State}; Hope I'm not missing something here, but isn't this only defined in 3/20? So proxmox-router wouldn't compile until 3/20 is applied as well. > =20 > // make list_subdirs_api_method! work without an explicit proxmox-schema= dependency: > #[doc(hidden)] > diff --git a/proxmox-router/src/rpc_environment.rs b/proxmox-router/src/r= pc_environment.rs > index 8ce2d99d..e065504a 100644 > --- a/proxmox-router/src/rpc_environment.rs > +++ b/proxmox-router/src/rpc_environment.rs [snip]