Re: [PATCH datacenter-manager v2 0/9] refactor and partially fix #7371

["Lukas Wagner" <l.wagner@proxmox.com>]

On Tue Aug 18, 2026 at 3:25 PM CEST, Dominik Csapak wrote:
> the first 6 patches are pure refactors and should not change anything
> user visible, could be applied independently.
>
> patch 7-9 partially fix #7371 by showing the HA maintenance status
> of PVE nodes in various places.
>
> changes from v1:
> * fixed some display problems: NaN% when maxmem was set to 0.0,
>   0.0% cpu when the node was offline, fixed by not showing values for
>   offline nodes
> * add a new patch for showing tha badge too in the node card's title
> * various typo fixes
> * added #[serde(default)] to the new hastate field to allow
>   deserialization from older versions
> * some smaller fixes  (left over comments, naming, etc.)
>
> Dominik Csapak (9):
>   lib: api types: add new ResourceView type and move accessors there
>   lib: api types: resource: add 'node' helper to ResourceView
>   lib: api types: add guest specific getter to ResourceView
>   ui: pve: factor out the pve-manager version extraction
>   ui: renderer: use ResourceView for rendering
>   ui: pve: tree: reuse `PveResource` for `PveTreeNode`
>   ui: pve: show ha maintenance mode for nodes
>   ui: pve: node selector: show maintenance badge with node name
>   ui: pve: node: show HA maintenance badge
>
>  lib/pdm-api-types/src/resource.rs  | 301 ++++++++++++++++++++--------
>  server/src/api/resources.rs        |   1 +
>  ui/pwt-assets                      |   2 +-
>  ui/src/dashboard/top_entities.rs   |   5 +-
>  ui/src/guests.rs                   |   6 +-
>  ui/src/lib.rs                      |  23 +--
>  ui/src/pve/mod.rs                  |  73 ++++---
>  ui/src/pve/node/mod.rs             |  15 +-
>  ui/src/pve/tree.rs                 | 302 ++++++++++++++---------------
>  ui/src/renderer.rs                 |  66 ++++---
>  ui/src/widget/pve_node_selector.rs |  91 +++++----
>  ui/src/widget/resource_tree.rs     |  11 +-
>  12 files changed, 533 insertions(+), 363 deletions(-)


Looks good to me. Two minor things, see patch replies for details.

Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>