From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C2B9E1FF0A7 for ; Mon, 17 Aug 2026 14:01:47 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9603523D18; Mon, 17 Aug 2026 14:01:47 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 17 Aug 2026 14:00:50 +0200 Message-Id: From: "Christoph Heiss" To: "Lukas Wagner" Subject: Re: [PATCH datacenter-manager 15/16] ui: auto-installer: wizard: add checkbox to add target as new remote X-Mailer: aerc 0.22.0 References: <20260731143910.936881-1-c.heiss@proxmox.com> <20260731143910.936881-16-c.heiss@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786968030168 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.170 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7JTFRSAZ72RLLS3HDA6MMHZ3T3ASNJRT X-Message-ID-Hash: 7JTFRSAZ72RLLS3HDA6MMHZ3T3ASNJRT X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the review! On Tue Aug 4, 2026 at 1:39 PM CEST, Lukas Wagner wrote: > On Fri Jul 31, 2026 at 4:35 PM CEST, Christoph Heiss wrote: >> Signed-off-by: Christoph Heiss >> --- >> .../remotes/auto_installer/prepared_answer_add_wizard.rs | 1 + >> ui/src/remotes/auto_installer/prepared_answer_form.rs | 7 +++++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs= b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs >> index 03d78be8..a4ea66e0 100644 >> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs >> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs >> @@ -81,6 +81,7 @@ impl AddAnswerWizardProperties { >> // post hook >> post_hook_base_url: pdm_origin(), >> post_hook_cert_fp: fingerprint, >> + post_hook_add_as_remote: true, >> // templating >> template_counters, >> // subscription >> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/= src/remotes/auto_installer/prepared_answer_form.rs >> index 6ee4b15a..e6eace8f 100644 >> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs >> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs >> @@ -985,6 +985,13 @@ pub fn render_auth_form( >> .tip(tr!("Optional certificate fingerprint")) >> .value(config.post_hook_cert_fp.clone()), >> ) >> + .with_field( >> + tr!("Provision As New Remote"), >> + Checkbox::new() >> + .name("post-hook-add-as-remote") >> + .tip(tr!("Only available for Virtual Environment and Ba= ckup Server. Add the target host as new remote to this Datacenter Manager i= nstance.")) > > In other words, available for all products PDM currently supports? I > think you could leave out the tooltip, this might actually confuse > users. Yes. Thought I state it explicitly, since the auto-installer can be used for PMG and PDM as well. But I see that this is also kind of implied, that it will only work for products which are (currently) supported by PDM. > >> + .default(config.post_hook_add_as_remote), >> + ) >> .with_large_custom_child( >> Container::from_tag("p") >> .key("post-hook-hint")