Re: [RFC datacenter-manager 1/1] fix #7135: openid auth: improve error logging

["Nicolas Frey" <n.frey@proxmox.com>]

On Thu Aug 13, 2026 at 1:02 PM CEST, Thomas Ellmenreich wrote:
> Thanks for having a look ;)
>
> On Thu Aug 13, 2026 at 11:27 AM CEST, Nicolas Frey wrote:
>
> [snip]
>
>> Consider adding a Fixes trailer, referencing the bug like so:
>> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7135
>
> Ah, yes, thank you very much for pointing this out. It's not the first time
> I've forgotten... xC
>
> [snip]
>
>> personally I'd rather see a verbose error message than none at all
>
> Good to hear!
>
> [snip]
>
>> also, why the alternate formatting ("{err:#}") [0] and not just "{err}"?
>>
>> [0] https://doc.rust-lang.org/std/fmt/#sign0
>
> I thought this error should display as much information as possible, so it
> should print all the 'anyhow' contexts. The 'alternate' formatting with '#'
> causes 'anyhow' to display all the different contexts [1]. Had I not used
> the 'alternate' formatting, the error I included would have been reduced to:
>
> ```
> ... proxmox-datacenter-privileged-api[616]: could not get opneid auth url: Request failed
> ```
>
> Which is also exactly what is currently sent to the client.
>
> [1]: https://github.com/dtolnay/anyhow/blob/bf3ed9149f4334c984c1ad252b534107b307078c/src/fmt.rs#L10-L15
>
> [snip]

Ah, thanks for the explanation! I think it might be good to include
that rationale in the commit message (i.e. why we want to have such
verbose logging here)