From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0A9AD1FF0E3 for ; Tue, 04 Aug 2026 13:39:15 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C8F30216E1; Tue, 04 Aug 2026 13:39:14 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Tue, 04 Aug 2026 13:39:11 +0200 Message-Id: From: "Lukas Wagner" To: "Christoph Heiss" , Subject: Re: [PATCH proxmox 05/16] installer-types: systeminfo: add check for API token creation capability Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260731143910.936881-1-c.heiss@proxmox.com> <20260731143910.936881-6-c.heiss@proxmox.com> In-Reply-To: <20260731143910.936881-6-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785843539699 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.237 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5DJT74SBRPVD2KI6YNRJSVWKYRQPHVRZ X-Message-ID-Hash: 5DJT74SBRPVD2KI6YNRJSVWKYRQPHVRZ X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 31, 2026 at 4:35 PM CEST, Christoph Heiss wrote: > +/// Represents a (major, minor, patch) product version tuple. > +#[derive(Debug, PartialEq, Eq)] > +pub struct ProductVersion(pub u32, pub u32, pub u32); > + > +impl PartialOrd for ProductVersion { > + fn partial_cmp(&self, other: &Self) -> Option { > + match ( > + self.0.cmp(&other.0), > + self.1.cmp(&other.1), > + self.2.cmp(&other.2), > + ) { > + (Ordering::Equal, Ordering::Equal, ord) =3D> Some(ord), > + (Ordering::Equal, ord, _) =3D> Some(ord), > + (ord, _, _) =3D> Some(ord), > + } > + } Same here, you could use `Ordering::then` here :) > } > =20