From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1B35F1FF0E3 for ; Tue, 04 Aug 2026 13:39:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A8E8F216A0; Tue, 04 Aug 2026 13:38:59 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 04 Aug 2026 13:38:55 +0200 Message-Id: From: "Lukas Wagner" To: "Christoph Heiss" , Subject: Re: [PATCH proxmox/installer/datacenter-manager 00/16] auto-installer: add installed target systems as new remotes X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260731143910.936881-1-c.heiss@proxmox.com> In-Reply-To: <20260731143910.936881-1-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785843524053 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.243 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FBVK7ZQHML2PDOF4BDGZDQV24M7S2CO5 X-Message-ID-Hash: FBVK7ZQHML2PDOF4BDGZDQV24M7S2CO5 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 31, 2026 at 4:35 PM CEST, Christoph Heiss wrote: > Adds a new checkbox to the "Authentication" tab of the wizard for > creating/editing prepared auto-installer answers. > > When checked, the installer (in the post-hook) will create a new API toke= n on > the freshly installed system - akin to how PDM does it when creating a ne= w > token - and adds it a remote. > > Of course; only supported when installing PVE or PBS, as these are the > supported targets of PDM. > > The post-hook information schema (which is sent back to the answer server= ) is > expanded a bit to accommodate that with two new fields: > > - `cert-fingerprint`: The SHA256 fingerprint for the API, needed due to t= he > default self-signed certificates. > - `api-token`: Holds the ID of the created token and its secret. > Looks very good already, great work! Only left some minor notes regarding code style, but those were mostly personal preference or cosmetical. Reviewed-by: Lukas Wagner I'll try to get around to testing these changes as well in the next couple days.