From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5624F1FF13A for ; Wed, 27 May 2026 16:16:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16B0D1EE40; Wed, 27 May 2026 16:16:55 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 27 May 2026 16:16:20 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager 1/6] server: api: certificates: allow anybody to query the certificate info From: "Lukas Wagner" To: "Filip Schauer" , "Shannon Sterz" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260527125217.260760-1-s.sterz@proxmox.com> <20260527125217.260760-2-s.sterz@proxmox.com> <170ee830-326c-4d9c-a64a-4cebe5bbe764@proxmox.com> In-Reply-To: <170ee830-326c-4d9c-a64a-4cebe5bbe764@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779891354291 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [certificates.rs] Message-ID-Hash: NJ7AQHWWL775U2W2MTM5VJYJUM5FMTOM X-Message-ID-Hash: NJ7AQHWWL775U2W2MTM5VJYJUM5FMTOM X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed May 27, 2026 at 4:12 PM CEST, Filip Schauer wrote: > On 27/05/2026 14:52, Shannon Sterz wrote: >> diff --git a/server/src/api/nodes/certificates.rs=20 >> b/server/src/api/nodes/certificates.rs >> index fc12e47..61e6bf9 100644 >> --- a/server/src/api/nodes/certificates.rs >> +++ b/server/src/api/nodes/certificates.rs >> @@ -60,7 +60,7 @@ fn get_certificate_info() -> Result { >> }, >> }, >> access: { >> - permission: &Permission::Privilege(&["system", "certificates"],=20 >> PRIV_SYS_AUDIT, false), >> + permission: &Permission::Anybody, >> }, >> returns: { >> type: Array, > > PRIV_SYS_AUDIT is now unused: > > warning: unused import: `PRIV_SYS_AUDIT` > =C2=A0 --> server/src/api/nodes/certificates.rs:16:21 > =C2=A0 =C2=A0| > 16 | use pdm_api_types::{PRIV_SYS_AUDIT, PRIV_SYS_MODIFY}; > =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0^^^^^^^^^^^^^^ > =C2=A0 =C2=A0| > =C2=A0 =C2=A0=3D note: `#[warn(unused_imports)]` (part of `#[warn(unused= )]`) on by=20 > default pushed a fixup removing the warning, no need for a patch