From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A05DD1FF146 for ; Tue, 26 May 2026 15:52:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F39B8AF9; Tue, 26 May 2026 15:52:21 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 15:52:17 +0200 Message-Id: Subject: applied: [PATCH datacenter-manager] ui: remove URL encoding from token ID during creation From: "Lukas Wagner" To: "Shan Shaji" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260526125912.454182-1-s.shaji@proxmox.com> In-Reply-To: <20260526125912.454182-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779803513322 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: L4Z57PFBZ52HGGWLFL7ZVCLTKMTRFE66 X-Message-ID-Hash: L4Z57PFBZ52HGGWLFL7ZVCLTKMTRFE66 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 26, 2026 at 2:59 PM CEST, Shan Shaji wrote: > When creating a new token via the UI, token IDs containing hyphens > ("-") were URL-encoded. This caused the API request to fail > with a 400 Bad Request error, preventing the token from being > generated. > > Fixed the issue by removing the unnecessary URL encoding from the > token ID before sending the request. > > Signed-off-by: Shan Shaji > --- > ui/src/remotes/auto_installer/token_panel.rs | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/ui/src/remotes/auto_installer/token_panel.rs b/ui/src/remote= s/auto_installer/token_panel.rs > index 06aed7bc..f8d26451 100644 > --- a/ui/src/remotes/auto_installer/token_panel.rs > +++ b/ui/src/remotes/auto_installer/token_panel.rs > @@ -384,12 +384,7 @@ async fn create_token(form_ctx: FormContext) -> Resu= lt > proxmox_time::parse_rfc3339(&form_ctx.read().get_field_text("exp= ire-at")).unwrap_or(0); > =20 > Ok(pdm_client() > - .add_autoinst_token( > - &percent_encode_component(&id), > - Some(comment), > - Some(enable), > - Some(expire), > - ) > + .add_autoinst_token(&id, Some(comment), Some(enable), Some(expir= e)) > .await?) > } > =20 applied, thanks! On a general note, sent another patch to enforce the token name schema directly at the API level (it was already enforced when saving the tokens to disk). Before applying, I double-checked that the schema is actually URL-safe, which it is. It is essentially gated by PROXMOX_SAFE_ID_REGEX, which is (?:[A-Za-z0-9_][A-Za-z0-9._\-]*) https://lore.proxmox.com/pdm-devel/20260526133056.334639-1-l.wagner@proxmox= .com/T/#u