From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: applied: [PATCH datacenter-manager] ui: snapshots: use constructor instead of custom `From` implementation
Date: Tue, 26 May 2026 11:50:30 +0200 [thread overview]
Message-ID: <DISIK19IDDNX.13QE2K86QJKY6@proxmox.com> (raw)
In-Reply-To: <20260526093123.1383837-1-d.csapak@proxmox.com>
On Tue May 26, 2026 at 11:31 AM CEST, Dominik Csapak wrote:
> having it return a dialog when a specific property is set instead of an
> embedded list is better done via a custom constructor. This way we don't
> have to passthrough the properties of the dialog we need, we save the
> extra property to differentiate, and the logic is not hidden inside the
> `From` implementation.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
applied, thanks!
prev parent reply other threads:[~2026-05-26 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 9:31 [PATCH datacenter-manager] ui: snapshots: use constructor instead of custom `From` implementation Dominik Csapak
2026-05-26 9:50 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DISIK19IDDNX.13QE2K86QJKY6@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox