From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DF25C1FF146 for ; Tue, 26 May 2026 11:16:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B25CA17974; Tue, 26 May 2026 11:16:38 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 11:16:04 +0200 Message-Id: To: =?utf-8?q?Fabian_Gr=C3=BCnbichler?= , Subject: Re: [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn X-Mailer: aerc 0.20.0 References: <20260522144633.475938-1-s.sterz@proxmox.com> <1779786372.iogkid8ktf.astroid@yuna.none> In-Reply-To: <1779786372.iogkid8ktf.astroid@yuna.none> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779786940717 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AESFU5MLG2EQ4I3GCLVV4TXI66AFRUSM X-Message-ID-Hash: AESFU5MLG2EQ4I3GCLVV4TXI66AFRUSM X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 26, 2026 at 11:08 AM CEST, Fabian Gr=C3=BCnbichler wrote: > On May 22, 2026 4:46 pm, Shannon Sterz wrote: >> to avoid users not setting this value themselves, as otherwise >> "host.example.com" would be set as default fqdn for an answer file >> config. >> >> Signed-off-by: Shannon Sterz >> --- >> ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs= b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs >> index f1b443e..64d746f 100644 >> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs >> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs >> @@ -55,7 +55,7 @@ impl AddAnswerWizardProperties { >> target_filter: BTreeMap::new(), >> // global options >> country: "at".to_owned(), >> - fqdn: "host.example.com".to_owned(), >> + fqdn: String::new(), > > this looks okay to me, though I wonder whether it wouldn't be better to > either default to > >> use_dhcp_fqdn: false, > > this, or use the placeholder with the template vars as default value but > do not accept it as valid? the placeholder with a template vars is already set in the ui here [1] as a proper placeholder (e.g. greyed-out; only shown when the field is empty). so setting an empty value here exposes this placeholder to the user and also mark the corresponding field as empty -> users get a validation error if they try to proceed without changing it. this approach also has the advantage of not special casing a specific value. sorry this could have been clearer in my commit message above. [1]: https://git.proxmox.com/?p=3Dproxmox-datacenter-manager.git;a=3Dblob;f= =3Dui/src/remotes/auto_installer/prepared_answer_form.rs;h=3D72d2856e33ac27= 59168cf0a4a56a7acd403f41d3;hb=3DHEAD#l328 >> keyboard: answer::KeyboardLayout::default(), >> mailto: String::new(), >> -- >> 2.47.3 >> >> >> >> >> >>