From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v3 6/6] ui: views: add map component
Date: Fri, 22 May 2026 15:30:41 +0200 [thread overview]
Message-ID: <DIP8QFLP8MOL.KNBXCJN8NAHQ@proxmox.com> (raw)
In-Reply-To: <20260522083412.1223719-12-d.csapak@proxmox.com>
On Fri May 22, 2026 at 10:34 AM CEST, Dominik Csapak wrote:
> this uses the WorldMap from yew widget toolkit together with the added
> world-map.json to show a world map on a custom view. This shows the
> remotes which have a location in the config and their status.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
-->8 snip 8<--
> @@ -251,7 +256,27 @@ impl ViewComp {
> link.send_message(Msg::LoadingResult(LoadingResult::SubscriptionInfo(res)));
> };
>
> - join!(status_future, entities_future, tasks_future, subs_future);
> + let location_future = async {
> + if required.locations {
> + let mut params = json!({});
> + // max-age for location has a sensible backend default and does not need to be
> + // updated as often, except if forced
> + if max_age == 0 {
> + params["max-age"] = 0.into();
> + }
> + add_view_filter(&mut params);
> + let res = http_get("/resources/location-info", Some(params)).await;
> + link.send_message(Msg::LoadingResult(LoadingResult::Locations(res)));
> + }
> + };
> +
> + join!(
> + status_future,
> + entities_future,
> + tasks_future,
> + subs_future,
> + location_future
> + );
imo it might worth revisiting the approach i suggest for this last year
before we shipped the views [1]. otherwise, this will just create more
and more churn as we go on. i'll see that i can get around to this after
the release.
[1]: https://lore.proxmox.com/pdm-devel/DDQH4208RAP8.28R3YO54Z8UX2@proxmox.com/
-->8 snip 8<--
next prev parent reply other threads:[~2026-05-22 13:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 8:33 [PATCH datacenter-manager/proxmox-geojson-data/yew-widget-toolkit/yew-widget-toolkit-assets v3 00/11] add a new map widget for custom views Dominik Csapak
2026-05-22 8:33 ` [PATCH yew-widget-toolkit v3 1/3] js-helper: add client-to-svg-coordinate conversion helper Dominik Csapak
2026-05-22 8:33 ` [PATCH yew-widget-toolkit v3 2/3] widget: charts: add interactive Map with zoom/pan and clustering Dominik Csapak
2026-05-22 13:30 ` Shannon Sterz
2026-05-22 8:33 ` [PATCH yew-widget-toolkit v3 3/3] widget: charts: add WorldMap with GeoJSON rendering Dominik Csapak
2026-05-22 8:34 ` [PATCH yew-widget-toolkit-assets v3 1/1] charts: add necessary classes for Map Dominik Csapak
2026-05-22 8:34 ` [PATCH proxmox-geojson-data v3 1/1] initial commit Dominik Csapak
2026-05-22 13:30 ` Shannon Sterz
2026-05-22 8:34 ` [PATCH datacenter-manager v3 1/6] server: pbs client: add node_config method Dominik Csapak
2026-05-22 8:34 ` [PATCH datacenter-manager v3 2/6] lib/api: add 'location-info' api call with cached information Dominik Csapak
2026-05-22 13:30 ` Shannon Sterz
2026-05-22 8:34 ` [PATCH datacenter-manager v3 3/6] lib/api: add new 'remote-list' info to the resource status Dominik Csapak
2026-05-22 8:34 ` [PATCH datacenter-manager v3 4/6] server: serve geojson worldmap Dominik Csapak
2026-05-22 8:34 ` [PATCH datacenter-manager v3 5/6] ui: views: refactor required api call info into struct Dominik Csapak
2026-05-22 8:34 ` [PATCH datacenter-manager v3 6/6] ui: views: add map component Dominik Csapak
2026-05-22 13:30 ` Shannon Sterz [this message]
2026-05-22 9:38 ` [PATCH datacenter-manager/proxmox-geojson-data/yew-widget-toolkit/yew-widget-toolkit-assets v3 00/11] add a new map widget for custom views Thomas Lamprecht
2026-05-22 13:33 ` Shannon Sterz
2026-05-24 2:31 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIP8QFLP8MOL.KNBXCJN8NAHQ@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox