From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A02921FF137 for ; Tue, 14 Apr 2026 14:13:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D56EB16FBF; Tue, 14 Apr 2026 14:14:24 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Tue, 14 Apr 2026 14:13:51 +0200 Message-Id: Subject: Re: [PATCH installer v3 35/38] fetch-answer: http: prefer json over toml for answer format From: "Lukas Wagner" To: "Christoph Heiss" , Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260403165437.2166551-1-c.heiss@proxmox.com> <20260403165437.2166551-36-c.heiss@proxmox.com> In-Reply-To: <20260403165437.2166551-36-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776168755568 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3HGMJLJL4RB444IGGR6DG5VAUBO7PI5G X-Message-ID-Hash: 3HGMJLJL4RB444IGGR6DG5VAUBO7PI5G X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Apr 3, 2026 at 6:54 PM CEST, Christoph Heiss wrote: > Signed-off-by: Christoph Heiss > --- > Changes v2 -> v3: > * new patch > > .../src/fetch_plugins/http.rs | 43 +++++++++++++++---- > 1 file changed, 34 insertions(+), 9 deletions(-) > Code LGTM, but I think there should be some rationale in the commit message that explains the change. For the code itself: Reviewed-by: Lukas Wagner