From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B07B01FF13C for ; Thu, 02 Apr 2026 15:47:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E4CDF1B95B; Thu, 2 Apr 2026 15:48:07 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 02 Apr 2026 15:48:05 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v2 1/4] api: return global cpu/memory/storage statistics From: "Lukas Wagner" To: "Dominik Csapak" , "Lukas Wagner" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260330131044.693709-1-d.csapak@proxmox.com> <20260330131044.693709-2-d.csapak@proxmox.com> <1fc88a7c-1b5d-4426-bf18-6a1b3d245e66@proxmox.com> In-Reply-To: <1fc88a7c-1b5d-4426-bf18-6a1b3d245e66@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775137626686 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.446 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DYSRELOPQ375HLVFUQ33OUKSNKLDEEEG X-Message-ID-Hash: DYSRELOPQ375HLVFUQ33OUKSNKLDEEEG X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Apr 2, 2026 at 3:02 PM CEST, Dominik Csapak wrote: >>> +#[api] >>> +#[derive(Default, Serialize, Deserialize, Clone, PartialEq)] >>> +/// Statistics for CPU utilization >>> +pub struct CpuStatistics { >>> + /// Amount of threads utilized >>=20 >> 'thread' is a countable noun, so it should rather be "Number of threads" > > thanks, i'll fix it, but just to note, in that same file we have > many instances of this, for example: > > "Amount of running guests" > "Amount of online datastores" > "Amount of configured remotes" > > > which all seem to me like countable nouns? > > so we might want to clean that up for all of them Yeah, this would make sense! Feel free to include it as a separate patch in this series :)