Re: [PATCH datacenter-manager v2 0/4] add resource gauge panels to dashboard/views

Lukas Wagner
2026-04-01T11:34:43Z

On Mon Mar 30, 2026 at 3:07 PM CEST, Dominik Csapak wrote:
> This uses the new pie charts[0] to add gauge panels for resources to
> the dashboards/views. Either combined cpu/memory/storage or
> indidivually, for pve/pbs or combined counts.
>
> for this we have to sum the data up in the backend.
>
> I also added these to the default dashboard (since it's data from an api
> call we already query) but put that in a separate patch so we can easily
> decide to not apply that. (not sure if we want to change the default
> dashboard)
>
> Note that the pwt patches [0] have to be applied and the package
> has to be bumped first.
>
> changes from v1:
> * use wider angle for the charts
> * remove decimal precision in chart
> * move 'title' to bottom with the other text
> * reformat the cpu text a bit for clarity
> * add a 'MemoryStatus' struct (same fields as StorageStatus but with
> different description)
>
> 0: https://lore.proxmox.com/yew-devel/20260320160816.4113364-1-d.csapak@proxmox.com/
>
> Dominik Csapak (4):
> api: return global cpu/memory/storage statistics
> ui: css: use mask for svg icons
> ui: dashboard: add new gauge panels widget type
> ui: dashboard: add resource gauges to default dashboard
>
> lib/pdm-api-types/src/lib.rs | 14 ++-
> lib/pdm-api-types/src/resource.rs | 27 +++++
> lib/pdm-api-types/src/views.rs | 15 +++
> server/src/api/resources.rs | 65 +++++++++---
> ui/css/pdm.scss | 35 +++----
> ui/src/dashboard/gauge_panel.rs | 160 ++++++++++++++++++++++++++++++
> ui/src/dashboard/mod.rs | 3 +
> ui/src/dashboard/view.rs | 19 +++-
> ui/src/dashboard/view/row_view.rs | 43 +++++++-
> 9 files changed, 347 insertions(+), 34 deletions(-)
> create mode 100644 ui/src/dashboard/gauge_panel.rs

I much prefer this new version from an aesthetic perspective, thanks for
the new version of this series!

This time I also reviewed the code more deeply. Looks good mostly, I
have some minor suggestions that were posted as replies to the
individual patches.

With the proposed changes included (and the proposed patch squashed in
or not - it's not a big deal if you don't):

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>