From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5C7EA1FF13A for ; Wed, 01 Apr 2026 13:37:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA74818D96; Wed, 1 Apr 2026 13:37:28 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 01 Apr 2026 13:36:55 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v2 3/4] ui: dashboard: add new gauge panels widget type From: "Lukas Wagner" To: "Dominik Csapak" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260330131044.693709-1-d.csapak@proxmox.com> <20260330131044.693709-4-d.csapak@proxmox.com> In-Reply-To: <20260330131044.693709-4-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775043358260 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2XLDD2NA2WVMVGI7JQJJY5DB6T7GFYOM X-Message-ID-Hash: 2XLDD2NA2WVMVGI7JQJJY5DB6T7GFYOM X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Mar 30, 2026 at 3:07 PM CEST, Dominik Csapak wrote: > diff --git a/ui/src/dashboard/view/row_view.rs b/ui/src/dashboard/view/ro= w_view.rs > index 673b4627..f220f954 100644 > --- a/ui/src/dashboard/view/row_view.rs > +++ b/ui/src/dashboard/view/row_view.rs > @@ -21,7 +21,7 @@ use crate::dashboard::view::EditingMessage; > =20 > use pdm_api_types::remotes::RemoteType; > use pdm_api_types::views::{ > - LeaderboardType, RowWidget, TaskSummaryGrouping, ViewLayout, WidgetT= ype, > + LeaderboardType, NodeResourceType, RowWidget, TaskSummaryGrouping, V= iewLayout, WidgetType, > }; > =20 > #[derive(Properties, PartialEq)] > @@ -539,6 +539,35 @@ fn create_menu(ctx: &yew::Context, new_= coords: Position) -> Menu { > ctx.link() > .callback(move |_| Msg::AddWidget(new_coords, widget.clone()= )) > }; > + let create_gauge_menu =3D |remote_type: Option| -> Menu = { > + Menu::new() > + .with_item( > + MenuItem::new(tr!("All Resources")).on_select(create_cal= lback( > + WidgetType::NodeResourceGauge { > + resource: None, > + remote_type, > + }, > + )), > + ) > + .with_item(MenuItem::new(tr!("CPU")).on_select(create_callba= ck( > + WidgetType::NodeResourceGauge { > + resource: Some(NodeResourceType::Cpu), > + remote_type, > + }, > + ))) > + .with_item(MenuItem::new(tr!("Memory")).on_select(create_cal= lback( > + WidgetType::NodeResourceGauge { > + resource: Some(NodeResourceType::Memory), > + remote_type, > + }, > + ))) > + .with_item(MenuItem::new(tr!("Storage")).on_select(create_ca= llback( > + WidgetType::NodeResourceGauge { > + resource: Some(NodeResourceType::Storage), > + remote_type, > + }, > + ))) > + }; > Menu::new() > .with_item( > MenuItem::new(tr!("Remote Panel")) > @@ -642,4 +671,16 @@ fn create_menu(ctx: &yew::Context, new_= coords: Position) -> Menu { > MenuItem::new(tr!("Resource Tree")) > .on_select(create_callback(WidgetType::ResourceTree)), > ) > + .with_item( > + MenuItem::new(tr!("Resource Usage")).menu( > + Menu::new() > + .with_item(MenuItem::new(tr!("All")).menu(create_gau= ge_menu(None))) > + .with_item( > + MenuItem::new(tr!("PVE")).menu(create_gauge_menu= (Some(RemoteType::Pve))), > + ) > + .with_item( > + MenuItem::new(tr!("PBS")).menu(create_gauge_menu= (Some(RemoteType::Pbs))), > + ), Sorry, forgot this in my initial reply: I'd also use the full product name here instead of the colloquially used acronyms. > + ), > + ) > }