From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 520821FF13A for ; Wed, 01 Apr 2026 13:34:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C37B318CC4; Wed, 1 Apr 2026 13:35:11 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 01 Apr 2026 13:34:28 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v2 0/4] add resource gauge panels to dashboard/views From: "Lukas Wagner" To: "Dominik Csapak" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260330131044.693709-1-d.csapak@proxmox.com> In-Reply-To: <20260330131044.693709-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775043212022 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.450 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2PRTDPWOPHWWUJKNMCWKZG6O3RHX6E5I X-Message-ID-Hash: 2PRTDPWOPHWWUJKNMCWKZG6O3RHX6E5I X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Mar 30, 2026 at 3:07 PM CEST, Dominik Csapak wrote: > This uses the new pie charts[0] to add gauge panels for resources to > the dashboards/views. Either combined cpu/memory/storage or > indidivually, for pve/pbs or combined counts. > > for this we have to sum the data up in the backend. > > I also added these to the default dashboard (since it's data from an api > call we already query) but put that in a separate patch so we can easily > decide to not apply that. (not sure if we want to change the default > dashboard) > > Note that the pwt patches [0] have to be applied and the package > has to be bumped first. > > changes from v1: > * use wider angle for the charts > * remove decimal precision in chart > * move 'title' to bottom with the other text > * reformat the cpu text a bit for clarity > * add a 'MemoryStatus' struct (same fields as StorageStatus but with > different description) > > 0: https://lore.proxmox.com/yew-devel/20260320160816.4113364-1-d.csapak@p= roxmox.com/ > > Dominik Csapak (4): > api: return global cpu/memory/storage statistics > ui: css: use mask for svg icons > ui: dashboard: add new gauge panels widget type > ui: dashboard: add resource gauges to default dashboard > > lib/pdm-api-types/src/lib.rs | 14 ++- > lib/pdm-api-types/src/resource.rs | 27 +++++ > lib/pdm-api-types/src/views.rs | 15 +++ > server/src/api/resources.rs | 65 +++++++++--- > ui/css/pdm.scss | 35 +++---- > ui/src/dashboard/gauge_panel.rs | 160 ++++++++++++++++++++++++++++++ > ui/src/dashboard/mod.rs | 3 + > ui/src/dashboard/view.rs | 19 +++- > ui/src/dashboard/view/row_view.rs | 43 +++++++- > 9 files changed, 347 insertions(+), 34 deletions(-) > create mode 100644 ui/src/dashboard/gauge_panel.rs I much prefer this new version from an aesthetic perspective, thanks for the new version of this series! This time I also reviewed the code more deeply. Looks good mostly, I have some minor suggestions that were posted as replies to the individual patches. With the proposed changes included (and the proposed patch squashed in or not - it's not a big deal if you don't): Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner