From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B25401FF138 for ; Wed, 18 Mar 2026 15:10:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5914D26A5; Wed, 18 Mar 2026 15:10:28 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Mar 2026 15:09:54 +0100 Message-Id: Subject: Re: [PATCH datacenter-manager/proxmox{,-backup,-yew-comp} 00/26] metric collection for the PDM host From: "Lukas Wagner" To: "Arthur Bied-Charreton" , "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260312135229.420729-1-l.wagner@proxmox.com> <3eovhoenhjowobftwr425s2q62nitqe4cpdwoxqs33hp4kh6lq@qxmldrdetrrd> In-Reply-To: <3eovhoenhjowobftwr425s2q62nitqe4cpdwoxqs33hp4kh6lq@qxmldrdetrrd> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773842952532 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JNDBM5BTWS4G6NVWTH6DZDOFG2QLN5RQ X-Message-ID-Hash: JNDBM5BTWS4G6NVWTH6DZDOFG2QLN5RQ X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Mar 16, 2026 at 2:42 PM CET, Arthur Bied-Charreton wrote: > On Thu, Mar 12, 2026 at 02:52:01PM +0100, Lukas Wagner wrote: >> This series add metric collection physical PDM hosts. >>=20 >> The patches for `proxmox` introduce three new crates: >> - proxmox-disks: broken out from proxmox-backup, needed to read disk s= tats >> - proxmox-parallel-handler: also broken out from proxmox-backup, >> needed as a dependency for proxmox-disks. Since the scope was manage= able, >> this series improves the existing code a bit by adding a dedicated e= rror type, >> some documentation and basic unit tests >> - proxmox-procfs: as a new home for any procfs related modules. this p= atch series adds >> a `pressure` module for reading pressure stall information for the h= ost and cgroups. >> The general idea is that we should move other procfs helpers from pr= oxmox-sys into >> this new crate, but to avoid scope explosion this is not done as a p= art of this >> series >>=20 >> The patches for proxmox-backup just switch over to the new moved impleme= ntations of proxmox-disks >> and proxmox-parallel-handler. >>=20 >> The patches for proxmox-yew-comp slight adapt the existing NodeStatusPan= el to allow the application >> to inject child components into the same panel. >>=20 >> The proxmox-datacenter-manager patches do some initial refactoring (nami= ng), and then add the needed >> collection loop, API types and UI elements. > [...] > > Looks very nice, gave this a spin on my PDM VM, everything works, the > metrics are being collected & updated, and they are consistent with what= =20 > I see on my machine. > > Responded to some patches directly with some comments, modulo that > consider this series: > > Reviewed-by: Arthur Bied-Charreton > Tested-by: Arthur Bied-Charreton Thanks for the review, Arthur! I'll try to send a v2 with these minor improvements in the next days, I'll include your T-b and R-b trailers there!