From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1D9A91FF138 for ; Wed, 18 Mar 2026 14:54:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DD50920A7; Wed, 18 Mar 2026 14:54:43 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Mar 2026 14:54:38 +0100 Message-Id: Subject: Re: [PATCH proxmox 06/26] disks: import from Proxmox Backup Server From: "Lukas Wagner" To: "Arthur Bied-Charreton" , "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260312135229.420729-1-l.wagner@proxmox.com> <20260312135229.420729-7-l.wagner@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773842036677 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HKQIOHQC76N3F3QSF6IBJZPKO26HNIBB X-Message-ID-Hash: HKQIOHQC76N3F3QSF6IBJZPKO26HNIBB X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Mar 16, 2026 at 2:13 PM CET, Arthur Bied-Charreton wrote: > On Thu, Mar 12, 2026 at 02:52:07PM +0100, Lukas Wagner wrote: >> This is based on the disks module from PBS and left unchanged. >>=20 >> The version has not been set to 1.0 yet since it seems like this crate >> could use a bit a cleanup (custom error type instead of anyhow, >> documentation). >>=20 > LGTM besides one small copy paste error, comment inline >> Signed-off-by: Lukas Wagner >> --- >> Cargo.toml | 6 + >> proxmox-disks/Cargo.toml | 30 + >> proxmox-disks/debian/changelog | 5 + >> proxmox-disks/debian/control | 94 ++ >> proxmox-disks/debian/copyright | 18 + >> proxmox-disks/debian/debcargo.toml | 7 + >> proxmox-disks/src/lib.rs | 1396 ++++++++++++++++++++++++++++ >> proxmox-disks/src/lvm.rs | 60 ++ >> proxmox-disks/src/parse_helpers.rs | 52 ++ >> proxmox-disks/src/smart.rs | 227 +++++ >> proxmox-disks/src/zfs.rs | 205 ++++ >> proxmox-disks/src/zpool_list.rs | 294 ++++++ >> proxmox-disks/src/zpool_status.rs | 496 ++++++++++ >> 13 files changed, 2890 insertions(+) >> create mode 100644 proxmox-disks/Cargo.toml >> create mode 100644 proxmox-disks/debian/changelog >> create mode 100644 proxmox-disks/debian/control >> create mode 100644 proxmox-disks/debian/copyright >> create mode 100644 proxmox-disks/debian/debcargo.toml >> create mode 100644 proxmox-disks/src/lib.rs >> create mode 100644 proxmox-disks/src/lvm.rs >> create mode 100644 proxmox-disks/src/parse_helpers.rs >> create mode 100644 proxmox-disks/src/smart.rs >> create mode 100644 proxmox-disks/src/zfs.rs >> create mode 100644 proxmox-disks/src/zpool_list.rs >> create mode 100644 proxmox-disks/src/zpool_status.rs >>=20 > [...] >> @@ -154,6 +159,7 @@ proxmox-async =3D { version =3D "0.5.0", path =3D "p= roxmox-async" } >> proxmox-base64 =3D { version =3D "1.0.0", path =3D "proxmox-base64" } >> proxmox-compression =3D { version =3D "1.0.0", path =3D "proxmox-compre= ssion" } >> proxmox-daemon =3D { version =3D "1.0.0", path =3D "proxmox-daemon" } >> +proxmox-disks =3D { version =3D "0.1.0", path =3D "proxmox-daemon" } > Should probably be proxmox-disks :) Yes, thanks! Probably didn't notice it because no crate in the workspace actually depends on proxmox-disks... >> proxmox-fixed-string =3D { version =3D "0.1.0", path =3D "proxmox-fixed= -string" } >> proxmox-http =3D { version =3D "1.0.5", path =3D "proxmox-http" } >> proxmox-http-error =3D { version =3D "1.0.0", path =3D "proxmox-http-er= ror" } > [...]