From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 42FEE1FF139 for ; Tue, 24 Feb 2026 14:06:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7681CA4FE; Tue, 24 Feb 2026 14:07:24 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 24 Feb 2026 14:06:49 +0100 Message-Id: From: "Lukas Wagner" To: "Shan Shaji" , Subject: Re: [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260218164135.413762-1-s.shaji@proxmox.com> In-Reply-To: <20260218164135.413762-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771938393964 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UFGH3QSIUEQJE5LFNMJLHA5DQRQYIMMN X-Message-ID-Hash: UFGH3QSIUEQJE5LFNMJLHA5DQRQYIMMN X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Feb 18, 2026 at 5:41 PM CET, Shan Shaji wrote: > If a user removed a remote without deleting its associated token, > PDM would not allow re-adding the same remote unless the token > was changed. To fix this, support for optionally deleting the token > on the remote has been added. > > new changes: > - use ConfirmDialog widget for creating the confirmation dialog. > - add token deletion as opt-out feature. > > History > =3D=3D=3D=3D=3D=3D=3D > > changes since v3: Thanks @Lukas and @Maximiliano > - addressed nit comments. > - percent-encode the `userid` parameter. > - rename PbsClient's delete_admin_token function to delete_token. > - by default set the CLIs `delete-token` option to `true`. So by default > the token will be deleted unless the option is set to false. > - remove `type` attribute from the `delete-token` schema. > - fix the alignment of checkbox and text. > > changes since v2: > - regenerate the `delete_token` method. The new generate code has > `percent_encoding` wrapped around the params to handle non-alphanumeric > characters.=20 > > changes since v3: > - locked the remote config inorder to avoid race condition. Thanks @Micha= el > - included missing admin cli implementation. Thanks @Michael > - addressed nit comments. Thanks @Shannon > LGTM! Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner