From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C8CE51FF141 for ; Fri, 13 Feb 2026 14:20:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E9463B36; Fri, 13 Feb 2026 14:21:44 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Feb 2026 14:21:41 +0100 Message-Id: Subject: Re: [PATCH datacenter-manager v3 6/6] cli: admin: add `delete-token` option to delete token from remote From: "Lukas Wagner" To: "Shan Shaji" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260211152016.445817-1-s.shaji@proxmox.com> <20260211152016.445817-7-s.shaji@proxmox.com> In-Reply-To: <20260211152016.445817-7-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770988898437 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WTQ3A22MFPXMNZTLUYVHBFKFWN2Z4BNR X-Message-ID-Hash: WTQ3A22MFPXMNZTLUYVHBFKFWN2Z4BNR X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Shan, thanks for the patch. Some notes inline. On Wed Feb 11, 2026 at 4:20 PM CET, Shan Shaji wrote: > Inorder to allow deleting the remote API token from PDM, added optional > boolean flag. > > Signed-off-by: Shan Shaji > --- > > **note**: No changes since v2. This was not included in v1. =20 > > cli/admin/src/remotes.rs | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/cli/admin/src/remotes.rs b/cli/admin/src/remotes.rs > index edd3fd8..6702667 100644 > --- a/cli/admin/src/remotes.rs > +++ b/cli/admin/src/remotes.rs > @@ -217,16 +217,28 @@ fn update_remote( > input: { > properties: { > id: { schema: REMOTE_ID_SCHEMA }, > + "delete-token": { > + type: bool, > + optional: true, > + description: "Remove the API-Token from remote." Same thing here that I already elaborated on in the client CLI tool: - type - default - description > + } > } > } > )] > -/// Add a new remote. > -fn remove_remote(id: String, rpcenv: &mut dyn RpcEnvironment) -> Result<= (), Error> { > - let param =3D json!({ "id": id }); > +/// Remove a new remote. > +async fn remove_remote( > + id: String, > + delete_token: Option, > + rpcenv: &mut dyn RpcEnvironment, > +) -> Result<(), Error> { > + let mut param =3D json!({ "id": id }); > + if delete_token.is_some() { > + param["delete-token"] =3D delete_token.into(); > + } > =20 > let info =3D &dc_api::remotes::API_METHOD_REMOVE_REMOTE; > match info.handler { > - ApiHandler::Sync(handler) =3D> (handler)(param, info, rpcenv).ma= p(drop), > + ApiHandler::Async(handler) =3D> (handler)(param, info, rpcenv).a= wait.map(drop), > _ =3D> unreachable!(), > } > }