From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A08CF1FF141 for ; Fri, 13 Feb 2026 14:20:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44E4F3A16; Fri, 13 Feb 2026 14:21:14 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Feb 2026 14:21:11 +0100 Message-Id: To: "Shan Shaji" , Subject: Re: [PATCH datacenter-manager v3 4/6] cli: client: add `delete-token` option to delete token from remote From: "Lukas Wagner" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260211152016.445817-1-s.shaji@proxmox.com> <20260211152016.445817-5-s.shaji@proxmox.com> In-Reply-To: <20260211152016.445817-5-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770988868464 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YXLV7TZ44RDKUX7FIHLZ3GRCUHME6DXC X-Message-ID-Hash: YXLV7TZ44RDKUX7FIHLZ3GRCUHME6DXC X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, some notes inline. On Wed Feb 11, 2026 at 4:20 PM CET, Shan Shaji wrote: > Signed-off-by: Shan Shaji > --- > =20 > **note:** No changes since v2 > =20 > cli/client/src/remotes.rs | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/cli/client/src/remotes.rs b/cli/client/src/remotes.rs > index 4145dac..0b4df3c 100644 > --- a/cli/client/src/remotes.rs > +++ b/cli/client/src/remotes.rs > @@ -116,12 +116,17 @@ async fn update_remote(id: String, updater: RemoteU= pdater) -> Result<(), Error> > input: { > properties: { > id: { schema: REMOTE_ID_SCHEMA }, > + "delete-token": { > + type: bool, > + optional: true, > + description: "Remove the API-Token from remote." Since this is the text shown in the help text in the CLI, it could be nice to phrase more explicitly what exactly this flag is doing, for instance: "Remove the API token used by Proxmox Datacenter Manager from the remote" Also, same here as in the other patch, you can drop the `type` and use `default: false` ... > + } > } > } > )] > -/// Add a new remote. > -async fn delete_remote(id: String) -> Result<(), Error> { > - client()?.delete_remote(&id).await?; > +/// Delete a remote. > +async fn delete_remote(id: String, delete_token: Option) -> Result= <(), Error> { ... and then just have `delete_token: bool` here ... > + client()?.delete_remote(&id, &delete_token).await?; ... and Some(&delete_token) here. > Ok(()) > } > =20 adding the default to the schema has the big benefit that these are shown in the help text of the CLI tool: Optional parameters: --delete-token (default=3Dfalse) Remove the API-Token from remote.