From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 816901FF141 for ; Fri, 13 Feb 2026 14:18:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 021C1377C; Fri, 13 Feb 2026 14:19:28 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Feb 2026 14:19:23 +0100 Message-Id: To: "Shan Shaji" , Subject: Re: [PATCH datacenter-manager/proxmox v3 0/7] fix #6914: add option to remove already existing token From: "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260211152016.445817-1-s.shaji@proxmox.com> In-Reply-To: <20260211152016.445817-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770988760656 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YX6KDDS53LX72FUABUAVGLT5YNCMXG2A X-Message-ID-Hash: YX6KDDS53LX72FUABUAVGLT5YNCMXG2A X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Feb 11, 2026 at 4:20 PM CET, Shan Shaji wrote: > **note**: Sending v3 because the generated code for the delete_token > method in pve-api-types has changed. I rebased the series onto master and > re-tested the changes.=20 > > If a user removed a remote without deleting its associated token, > PDM would not allow re-adding the same remote unless the token > was changed. To fix this, support for optionally deleting the token > from the remote has been added. > > This patch series adds support to delete the token using an optional > boolean flag in CLIs ie. on both admin and client. Additionaly, added a > check box inside the UI that allow users to choose whether to=20 > delete the token while removing the remote. > Seems to work fine, test both, PVE and PBS remotes. Can confirm the removing the token works as expected. Tested-by: Lukas Wagner Left some comments with the individual patches for improvements for v4.