From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6FC0D1FF13F for ; Thu, 12 Feb 2026 14:17:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 239A0F69B; Thu, 12 Feb 2026 14:18:40 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 12 Feb 2026 14:18:35 +0100 Message-Id: To: "Shannon Sterz" , Subject: Re: [PATCH datacenter-manager v2 0/2] fix adding users manually for openid/ldap/ad realms From: "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260209094349.34075-1-s.sterz@proxmox.com> In-Reply-To: <20260209094349.34075-1-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770902313148 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 67XN4U65GZBYS5MA2RR4QT6EMOTO4Z5T X-Message-ID-Hash: 67XN4U65GZBYS5MA2RR4QT6EMOTO4Z5T X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Feb 9, 2026 at 10:43 AM CET, Shannon Sterz wrote: > currently, when adding a new user manually through the ui, a password > needs to be entered for all realms but the pam realm. however, only for > the pdm/product realm itself do we store a password. so don't require > these fields for any other realm. > > also adds a dummy authenticator implementation for openid realms. this > is necessary, because looking up whether an authenticator is present is > used for validating that a realm exists when adding a user. so add a > dummy authenticator for openid realms. > > changes since v1 > > * dropped a `cargo fmt` commit that is no longer necessary > * patch 1/1 of the original series was applied to yew-comp already, so i > dropped it here > * fixed a typo in the commit message of 2/2 > > proxmox-datacenter-manager: > > Shannon Sterz (2): > fix #7182: server: auth: add dummy openid authenticator > ui: set product realm so that the add user dialogs are rendered > properly > > server/src/auth/mod.rs | 61 ++++++++++++++++++++++++++++++------- > ui/src/configuration/mod.rs | 2 +- > 2 files changed, 51 insertions(+), 12 deletions(-) > > > Summary over all repositories: > 2 files changed, 51 insertions(+), 12 deletions(-) > > -- > Generated by git-murpp 0.8.1 Looks good to me. Tested it against a locally running keycloak server. Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner