From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 039231FF138 for ; Wed, 04 Feb 2026 10:36:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DDAC0E57F; Wed, 4 Feb 2026 10:37:30 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Feb 2026 10:37:27 +0100 Message-Id: Subject: applied: [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control From: "Lukas Wagner" To: "Maximiliano Sandoval" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260202134926.403503-1-m.sandoval@proxmox.com> In-Reply-To: <20260202134926.403503-1-m.sandoval@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770197771539 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QRPNS7YVCAZTY22GGQ4WFYLBBI3JB3C2 X-Message-ID-Hash: QRPNS7YVCAZTY22GGQ4WFYLBBI3JB3C2 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Feb 2, 2026 at 2:49 PM CET, Maximiliano Sandoval wrote: > To match the changes made in > https://git.proxmox.com/?p=3Dproxmox.git;a=3Dcommitdiff;h=3D47defa79bd109= 91d28757a690f7dc283805b2768. > > This fixes the following error while running `cargo build`: > > ``` > $ cargo build > Compiling pdm-api-types v1.0.0 (/home/msandoval/Projects/proxmox-datac= enter-manager/lib/pdm-api-types) > error[E0433]: failed to resolve: could not find `init` in `proxmox_access= _control` > --> lib/pdm-api-types/src/acl.rs:192:30 > | > 192 | impl proxmox_access_control::init::AccessControlConfig for AccessCo= ntrolConfig { > | ^^^^ could not find `init` in `proxmox= _access_control` > | > note: found an item that was configured out > --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:= 12:9 > | > 11 | #[cfg(feature =3D "acl")] > | --------------- the item is gated behind the `acl` feature > 12 | pub mod init; > | ^^^^ > > error[E0433]: failed to resolve: could not find `acl` in `proxmox_access_= control` > --> lib/pdm-api-types/src/acl.rs:257:50 > | > 257 | let components =3D proxmox_access_control::acl::split_acl_p= ath(path); > | ^^^ could not find= `acl` in `proxmox_access_control` > | > note: found an item that was configured out > --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:= 6:9 > | > 5 | #[cfg(feature =3D "acl")] > | --------------- the item is gated behind the `acl` feature > 6 | pub mod acl; > | ^^^ > > For more information about this error, try `rustc --explain E0433`. > error: could not compile `pdm-api-types` (lib) due to 2 previous errors > ``` > > Signed-off-by: Maximiliano Sandoval > --- > lib/pdm-api-types/Cargo.toml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/pdm-api-types/Cargo.toml b/lib/pdm-api-types/Cargo.toml > index d6429e6a..7aa7b64e 100644 > --- a/lib/pdm-api-types/Cargo.toml > +++ b/lib/pdm-api-types/Cargo.toml > @@ -14,7 +14,7 @@ serde.workspace =3D true > serde_plain.workspace =3D true > =20 > proxmox-acme-api.workspace =3D true > -proxmox-access-control.workspace =3D true > +proxmox-access-control =3D { workspace =3D true, features =3D ["acl"] } > proxmox-auth-api =3D { workspace =3D true, features =3D ["api-types"] } > proxmox-apt-api-types.workspace =3D true > proxmox-lang.workspace =3D true applied, thank you for the patch! As discussed off-list with you, I changed the commit message a bit, removing the quite noisy compiler output with a short textual explanation.