From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 192B01FF178 for ; Mon, 29 Dec 2025 15:53:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 519B11CE24; Mon, 29 Dec 2025 15:54:44 +0100 (CET) Mime-Version: 1.0 Date: Mon, 29 Dec 2025 15:54:10 +0100 Message-Id: From: "Lukas Wagner" To: "Shannon Sterz" , "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20251218142007.279631-1-l.wagner@proxmox.com> <20251218142007.279631-4-l.wagner@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767020024226 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 1/4] remote tasks: move implementation to server crate X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri Dec 19, 2025 at 2:50 PM CET, Shannon Sterz wrote: > On Thu Dec 18, 2025 at 3:20 PM CET, Lukas Wagner wrote: >> use server::{ >> - connection, >> - parallel_fetcher::{NodeResults, ParallelFetcher}, >> - pbs_client, >> - remote_tasks::{ >> - self, >> - task_cache::{GetTasks, NodeFetchSuccessMap, State, TaskCache, TaskCacheItem}, >> - KEEP_OLD_FILES, REMOTE_TASKS_DIR, ROTATE_AFTER, >> - }, >> + remote_tasks::{self, refresh_task, REMOTE_TASKS_DIR}, > > nit: could use module level imports here :) > Thanks, will be fixed for v2! >> task_utils, >> }; [...] >> >> >> loop { >> interval.tick().await; >> - if let Err(err) = do_tick(&mut task_state).await { >> + if let Err(err) = remote_tasks::refresh_task::handle_timer_tick(&mut task_state).await { > > nit: you already import `refresh_task` above. so drop `remote_tasks` in > front here, should also enable you to drop the `self` import above. > >> log::error!("error when fetching remote tasks: {err:#}"); >> } >> } >> } This as well :) _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel